From: Jakub Kicinski <kuba@kernel.org>
To: willemb@google.com
Cc: Jason Xing <kerneljasonxing@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, netdev@vger.kernel.org,
Jason Xing <kernelxing@tencent.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next v3 1/2] net-timestamp: filter out report when setting SOF_TIMESTAMPING_SOFTWARE
Date: Tue, 3 Sep 2024 12:19:40 -0700 [thread overview]
Message-ID: <20240903121940.6390b958@kernel.org> (raw)
In-Reply-To: <20240830153751.86895-2-kerneljasonxing@gmail.com>
On Fri, 30 Aug 2024 23:37:50 +0800 Jason Xing wrote:
> + if (val & SOF_TIMESTAMPING_RX_SOFTWARE &&
> + val & SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER)
> + return -EINVAL;
> - if (READ_ONCE(sk->sk_tsflags) & SOF_TIMESTAMPING_SOFTWARE)
> + if (tsflags & SOF_TIMESTAMPING_SOFTWARE &&
> + (tsflags & SOF_TIMESTAMPING_RX_SOFTWARE ||
> + !(tsflags & SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER)))
> has_timestamping = true;
> else
> tss->ts[0] = (struct timespec64) {0};
> }
> memset(&tss, 0, sizeof(tss));
> tsflags = READ_ONCE(sk->sk_tsflags);
> - if ((tsflags & SOF_TIMESTAMPING_SOFTWARE) &&
> + if ((tsflags & SOF_TIMESTAMPING_SOFTWARE &&
> + (tsflags & SOF_TIMESTAMPING_RX_SOFTWARE ||
> + skb_is_err_queue(skb) ||
> + !(tsflags & SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER))) &&
Willem, do you prefer to keep the:
tsflags & SOF_TIMESTAMPING_RX_SOFTWARE ||
!(tsflags & SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER)
conditions?IIUC we prevent both from being set at once. So
!(tsflags & SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER)
is sufficient (and, subjectively, more intuitive).
Question #2 -- why are we only doing this for SW stamps?
HW stamps for TCP are also all or nothing.
next prev parent reply other threads:[~2024-09-03 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 15:37 [PATCH net-next v3 0/2] net-timestamp: introduce a flag to filter out rx software report Jason Xing
2024-08-30 15:37 ` [PATCH net-next v3 1/2] net-timestamp: filter out report when setting SOF_TIMESTAMPING_SOFTWARE Jason Xing
2024-08-31 14:49 ` Willem de Bruijn
2024-08-31 15:00 ` Jason Xing
2024-09-03 19:19 ` Jakub Kicinski [this message]
2024-09-03 22:13 ` Willem de Bruijn
2024-09-03 23:29 ` Jason Xing
2024-09-04 9:14 ` Jason Xing
2024-09-04 20:25 ` Willem de Bruijn
2024-09-04 21:38 ` Jason Xing
2024-08-30 15:37 ` [PATCH net-next v3 2/2] rxtimestamp.c: add the test for SOF_TIMESTAMPING_OPT_RX_SOFTWARE_FILTER Jason Xing
2024-08-31 14:50 ` Willem de Bruijn
2024-09-02 1:49 ` kernel test robot
2024-09-02 2:41 ` Jason Xing
2024-09-02 4:25 ` Philip Li
2024-09-02 5:04 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903121940.6390b958@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kernelxing@tencent.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.