From: Simon Horman <horms@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com, kuba@kernel.org,
andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, kernel-team@meta.com, sanmanpradhan@meta.com,
sdf@fomichev.me, jdamato@fastly.com
Subject: Re: [PATCH net-next v3 2/2] eth: fbnic: Add support to fetch group stats
Date: Tue, 3 Sep 2024 13:52:01 +0100 [thread overview]
Message-ID: <20240903125201.GA1833@kernel.org> (raw)
In-Reply-To: <20240902173907.925023-3-mohsin.bashr@gmail.com>
On Mon, Sep 02, 2024 at 10:39:07AM -0700, Mohsin Bashir wrote:
> Add support for group stats for mac. The fbnic_set_counter help preserve
> the default values for counters which are not touched by the driver.
>
> The 'reset' flag in 'get_eth_mac_stats' allows to choose between
> resetting the counter to recent most value or fetching the aggregated
> values of the counter.
>
> The 'fbnic_stat_rd64' read 64b stats counters in an atomic fashion using
> read-read-read approach. This allows to isolate cases where counter is
> moving too fast making accuracy of the counter questionable.
>
> Command: ethtool -S eth0 --groups eth-mac
> Example Output:
> eth-mac-FramesTransmittedOK: 421644
> eth-mac-FramesReceivedOK: 3849708
> eth-mac-FrameCheckSequenceErrors: 0
> eth-mac-AlignmentErrors: 0
> eth-mac-OctetsTransmittedOK: 64799060
> eth-mac-FramesLostDueToIntMACXmitError: 0
> eth-mac-OctetsReceivedOK: 5134513531
> eth-mac-FramesLostDueToIntMACRcvError: 0
> eth-mac-MulticastFramesXmittedOK: 568
> eth-mac-BroadcastFramesXmittedOK: 454
> eth-mac-MulticastFramesReceivedOK: 276106
> eth-mac-BroadcastFramesReceivedOK: 26119
> eth-mac-FrameTooLongErrors: 0
>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
> ---
> V3: Fix nit
It might have been better to mention what the nit was (spelling).
>
> V2: https://lore.kernel.org/netdev/20240827205904.1944066-2-mohsin.bashr@gmail.com
>
> V1: https://lore.kernel.org/netdev/20240822184944.3882360-1-mohsin.bashr@gmail.com/
This above notwithstanding, this looks good to me: It implements standard
statistics, and there was no substantial review from v1 and v2 to address.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-03 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 17:39 [PATCH net-next v3 0/2] eth: Add basic ethtool support for fbnic Mohsin Bashir
2024-09-02 17:39 ` [PATCH net-next v3 1/2] eth: fbnic: Add " Mohsin Bashir
2024-09-03 12:54 ` Simon Horman
2024-09-02 17:39 ` [PATCH net-next v3 2/2] eth: fbnic: Add support to fetch group stats Mohsin Bashir
2024-09-03 12:52 ` Simon Horman [this message]
2024-09-04 12:20 ` [PATCH net-next v3 0/2] eth: Add basic ethtool support for fbnic patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903125201.GA1833@kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanmanpradhan@meta.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.