From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vadim Fedorenko <vadfed@meta.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Jiri Slaby <jirislaby@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v7 0/3] ptp: ocp: fix serial port information export
Date: Tue, 3 Sep 2024 10:40:23 +0200 [thread overview]
Message-ID: <2024090313-crewless-nearly-3ee2@gregkh> (raw)
In-Reply-To: <20240829183603.1156671-1-vadfed@meta.com>
On Thu, Aug 29, 2024 at 11:36:00AM -0700, Vadim Fedorenko wrote:
> Starting v6.8 the serial port subsystem changed the hierarchy of devices
> and symlinks are not working anymore. Previous discussion made it clear
> that the idea of symlinks for tty devices was wrong by design [1].
> This series implements additional attributes to expose the information
> and removes symlinks for tty devices.
>
> [1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/
>
> v6 -> v7:
> - fix issues with applying patches
> v5 -> v6:
> - split conversion to array to separate patch per Jiri's feedback
> - move changelog to cover letter
> v4 -> v5:
> - remove unused variable in ptp_ocp_tty_show
> v3 -> v4:
> - re-organize info printing to use ptp_ocp_tty_port_name()
> - keep uintptr_t to be consistent with other code
> v2 -> v3:
> - replace serial ports definitions with array and enum for index
> - replace pointer math with direct array access
> - nit in documentation spelling
> v1 -> v2:
> - add Documentation/ABI changes
>
> Vadim Fedorenko (3):
> ptp: ocp: convert serial ports to array
> ptp: ocp: adjust sysfs entries to expose tty information
> docs: ABI: update OCP TimeCard sysfs entries
>
> Documentation/ABI/testing/sysfs-timecard | 31 +++--
> drivers/ptp/ptp_ocp.c | 168 ++++++++++++++---------
> 2 files changed, 119 insertions(+), 80 deletions(-)
Thanks for doing this:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2024-09-03 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 18:36 [PATCH net v7 0/3] ptp: ocp: fix serial port information export Vadim Fedorenko
2024-08-29 18:36 ` [PATCH net v7 1/3] ptp: ocp: convert serial ports to array Vadim Fedorenko
2024-08-29 18:36 ` [PATCH net v7 2/3] ptp: ocp: adjust sysfs entries to expose tty information Vadim Fedorenko
2024-09-03 10:35 ` Paolo Abeni
2024-09-03 11:06 ` Vadim Fedorenko
2024-08-29 18:36 ` [PATCH net v7 3/3] docs: ABI: update OCP TimeCard sysfs entries Vadim Fedorenko
2024-09-03 8:40 ` Greg Kroah-Hartman [this message]
2024-09-03 13:50 ` [PATCH net v7 0/3] ptp: ocp: fix serial port information export patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024090313-crewless-nearly-3ee2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vadfed@meta.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.