Re: [Buildroot] [PATCH 1/1] package/ipmitool: only accept local PEN registry

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Mon,  2 Sep 2024 23:00:55 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> The https://www.iana.org/assignments/enterprise-numbers.txt is not a
> versioned URL, and that file is regularly updated, so it is not
> acceptable to change its hash each time.
> 
> Following Yann's suggestions [1], only local files are now accepted,
> removing the need to download the PEN registry and consequently verify
> the hash's correctness.
> 
> Fixes:
> - http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f
> 
> [1]: https://patchwork.ozlabs.org/project/buildroot/patch/20240824103634.1955431-1-dario.binacchi@amarulasolutions.com/
> Co-Developed-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>  package/ipmitool/Config.in   | 12 ++++++------
>  package/ipmitool/ipmitool.mk | 13 +++++--------
>  2 files changed, 11 insertions(+), 14 deletions(-)

I don't like this solution, having to download separately a file is
annoying.

Why not using:

  https://github.com/larseggert/iana-assignments

which precisely provides a versioned set of IANA documents, including
that enterprise-numbers file?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot