From: Christoph Hellwig <hch@lst.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Jinyoung Choi <j-young.choi@samsung.com>,
Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATCH] bio-integrity: don't restrict the size of integrity metadata
Date: Wed, 4 Sep 2024 07:19:14 +0200 [thread overview]
Message-ID: <20240904051914.GA13967@lst.de> (raw)
In-Reply-To: <e41b3b8e-16c2-70cb-97cb-881234bb200d@redhat.com>
On Tue, Sep 03, 2024 at 09:47:59PM +0200, Mikulas Patocka wrote:
> Hi Jens
>
> I added dm-integrity inline mode in the 6.11 merge window. I've found out
> that it doesn't work with large bios - the reason is that the function
> bio_integrity_add_page refuses to add more metadata than
> queue_max_hw_sectors(q). This restriction is no longer needed, because
> big bios are split automatically. I'd like to ask you if you could send
> this commit to Linus before 6.11 comes out, so that the bug is fixed
> before the final release.
This looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although between the patches from Keith and the prep patch for the
io_uring metadata series I'm not sure that splitting of bios with
integrity actually fully works. Although until we get the io_uring
passthrough code in we also won't have an easy way to exercise it either.
next prev parent reply other threads:[~2024-09-04 5:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 19:47 [PATCH] bio-integrity: don't restrict the size of integrity metadata Mikulas Patocka
2024-09-04 2:57 ` Ming Lei
2024-09-04 5:19 ` Christoph Hellwig [this message]
2024-09-04 13:02 ` Anuj gupta
2024-09-04 13:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904051914.GA13967@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=j-young.choi@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.