From: Simon Horman <horms@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH net v4 2/3] net: sched: consistently use rcu_replace_pointer() in taprio_change()
Date: Wed, 4 Sep 2024 11:19:15 +0100 [thread overview]
Message-ID: <20240904101915.GJ4792@kernel.org> (raw)
In-Reply-To: <20240903140708.3122263-2-dmantipov@yandex.ru>
On Tue, Sep 03, 2024 at 05:07:07PM +0300, Dmitry Antipov wrote:
> According to Vinicius (and carefully looking through the whole thing
> once again), txtime branch of 'taprio_change()' is not going to race
> against 'advance_sched()'. But using 'rcu_replace_pointer()' in the
> former may be a good idea as well.
Hi Dmitry,
If this is not a fix, then it should be targeted at net-next.
As the other two patches in the series do appear to be fixes,
that means the patch-set should be split into two: one for net
and one for net-next.
Also, please consider including a cover letter with
patch-sets with more than one patch.
> Suggested-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> v4: adjust subject to target net tree
> v3: unchanged since v2
> v2: added to the series
...
next prev parent reply other threads:[~2024-09-04 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 14:07 [PATCH net v4 1/3] net: sched: fix use-after-free in taprio_change() Dmitry Antipov
2024-09-03 14:07 ` [PATCH net v4 2/3] net: sched: consistently use rcu_replace_pointer() " Dmitry Antipov
2024-09-04 10:19 ` Simon Horman [this message]
2024-09-03 14:07 ` [PATCH net v4 3/3] net: sched: use RCU read-side critical section in taprio_dump() Dmitry Antipov
2024-09-04 10:17 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904101915.GJ4792@kernel.org \
--to=horms@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=kuba@kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.