From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Douglas Silva <doug.hs@proton.me>
Subject: [libgpiod][PATCH v2] build: imply --enable-bindings-glib for --enable-dbus
Date: Wed, 4 Sep 2024 16:01:27 +0200 [thread overview]
Message-ID: <20240904140127.58667-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
GLib bindings are required to build the D-Bus daemon. Enable them
automatically if --enable-dbus is passed to configure.
Fixes: a5ab76da1e0a ("dbus: add the D-Bus daemon, command-line client and tests")
Reported-by: Douglas Silva <doug.hs@proton.me>
Suggested-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
v1 -> v2:
- make the changes actually work
configure.ac | 52 +++++++++++++++++++++++++---------------------------
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/configure.ac b/configure.ac
index 1ac1002..92d3408 100644
--- a/configure.ac
+++ b/configure.ac
@@ -250,10 +250,35 @@ then
fi
fi
+AC_ARG_ENABLE([dbus],
+ [AS_HELP_STRING([--enable-dbus], [build dbus daemon [default=no]])],
+ [if test "x$enableval" == xyes; then with_dbus=true; fi],
+ [with_dbus=false])
+AM_CONDITIONAL([WITH_DBUS], [test "x$with_dbus" = xtrue])
+
AC_ARG_ENABLE([bindings-glib],
[AS_HELP_STRING([--enable-bindings-glib],[enable GLib 2.0 bindings [default=no]])],
[if test "x$enableval" = xyes; then with_bindings_glib=true; fi],
[with_bindings_glib=false])
+
+AC_DEFUN([FUNC_NOT_FOUND_DBUS],
+ [ERR_NOT_FOUND([$1()], [dbus daemon])])
+
+if test "x$with_dbus" = xtrue
+then
+ AC_CHECK_FUNC([daemon], [], [FUNC_NOT_FOUND_DBUS([daemon])])
+ AC_CHECK_FUNC([strverscmp], [], [FUNC_NOT_FOUND_DBUS([strverscmp])])
+ PKG_CHECK_MODULES([GUDEV], [gudev-1.0 >= 230])
+ AC_CHECK_PROG([has_gdbus_codegen], [gdbus-codegen], [true], [false])
+ if test "x$has_gdbus_codegen" = xfalse
+ then
+ AC_MSG_ERROR([gdbus-codegen not found - needed to build dbus daemon])
+ fi
+
+ # Imply GLib bindings for D-Bus
+ with_bindings_glib=true
+fi
+
AM_CONDITIONAL([WITH_BINDINGS_GLIB], [test "x$with_bindings_glib" = xtrue])
if test "x$with_bindings_glib" = xtrue
@@ -280,33 +305,6 @@ m4_ifdef([GOBJECT_INTROSPECTION_CHECK],
[GOBJECT_INTROSPECTION_CHECK([0.6.2])],
[AM_CONDITIONAL(HAVE_INTROSPECTION, test "x$found_introspection" = "xyes")])
-# Depends on GLib bindings so must come after
-AC_ARG_ENABLE([dbus],
- [AS_HELP_STRING([--enable-dbus], [build dbus daemon [default=no]])],
- [if test "x$enableval" == xyes; then with_dbus=true; fi],
- [with_dbus=false])
-AM_CONDITIONAL([WITH_DBUS], [test "x$with_dbus" = xtrue])
-
-AC_DEFUN([FUNC_NOT_FOUND_DBUS],
- [ERR_NOT_FOUND([$1()], [dbus daemon])])
-
-if test "x$with_dbus" = xtrue && test "x$with_bindings_glib" != xtrue
-then
- AC_MSG_ERROR([GLib bindings are required to build the dbus daemon - use --enable-bindings-glib])
-fi
-
-if test "x$with_dbus" = xtrue
-then
- AC_CHECK_FUNC([daemon], [], [FUNC_NOT_FOUND_DBUS([daemon])])
- AC_CHECK_FUNC([strverscmp], [], [FUNC_NOT_FOUND_DBUS([strverscmp])])
- PKG_CHECK_MODULES([GUDEV], [gudev-1.0 >= 230])
- AC_CHECK_PROG([has_gdbus_codegen], [gdbus-codegen], [true], [false])
- if test "x$has_gdbus_codegen" = xfalse
- then
- AC_MSG_ERROR([gdbus-codegen not found - needed to build dbus daemon])
- fi
-fi
-
AC_ARG_ENABLE([systemd],
[AS_HELP_STRING([--enable-systemd], [enable systemd support [default=no]])],
[if test "x$enableval" == xyes; then with_systemd=true; fi],
--
2.43.0
next reply other threads:[~2024-09-04 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 14:01 Bartosz Golaszewski [this message]
2024-09-04 14:09 ` [libgpiod][PATCH v2] build: imply --enable-bindings-glib for --enable-dbus Kent Gibson
2024-09-05 7:32 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904140127.58667-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=doug.hs@proton.me \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.