From: Jason Gunthorpe <jgg@nvidia.com>
To: Michael Guralnik <michaelgur@nvidia.com>
Cc: leonro@nvidia.com, linux-rdma@vger.kernel.org, saeedm@nvidia.com,
tariqt@nvidia.com
Subject: Re: [PATCH rdma-next 1/8] net/mlx5: Expand mkey page size to support 6 bits
Date: Wed, 4 Sep 2024 13:18:39 -0300 [thread overview]
Message-ID: <20240904161839.GM3915968@nvidia.com> (raw)
In-Reply-To: <20240904153038.23054-2-michaelgur@nvidia.com>
On Wed, Sep 04, 2024 at 06:30:31PM +0300, Michael Guralnik wrote:
> +#define mlx5_umem_find_best_pgsz(umem, dev, iova) \
> + ib_umem_find_best_pgsz( \
> + umem, \
> + __mlx5_log_page_size_to_bitmap( \
> + MLX5_CAP_GEN_2(dev->mdev, umr_log_entity_size_5) ? 6 : \
> + 5, \
> + 0), \
> + iova)
This can go in a real static inline function now.
Isn't is mlx5_mkx_find_best_pgsz ? It is only for mkc right?
> @@ -4221,8 +4223,7 @@ struct mlx5_ifc_mkc_bits {
>
> u8 reserved_at_1c0[0x19];
> u8 relaxed_ordering_read[0x1];
> - u8 reserved_at_1d9[0x1];
> - u8 log_page_size[0x5];
> + u8 log_page_size[0x6];
?
Why is this change OK without more changes? Doesn't it move
log_page_size forward by 1 bit?
Jason
next prev parent reply other threads:[~2024-09-04 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 15:30 [PATCH rdma-next 0/8] Introduce mlx5 Memory Scheme ODP Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 1/8] net/mlx5: Expand mkey page size to support 6 bits Michael Guralnik
2024-09-04 16:18 ` Jason Gunthorpe [this message]
2024-09-05 20:48 ` Michael Guralnik
2024-09-05 23:21 ` Jason Gunthorpe
2024-09-04 15:30 ` [PATCH rdma-next 2/8] net/mlx5: Expose HW bits for Memory scheme ODP Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 3/8] RDMA/mlx5: Add new ODP memory scheme eqe format Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 4/8] RDMA/mlx5: Enforce umem boundaries for explicit ODP page faults Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 5/8] RDMA/mlx5: Split ODP mkey search logic Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 6/8] RDMA/mlx5: Add handling for memory scheme page fault events Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 7/8] RDMA/mlx5: Add implicit MR handling to ODP memory scheme Michael Guralnik
2024-09-04 15:30 ` [PATCH rdma-next 8/8] net/mlx5: Handle memory scheme ODP capabilities Michael Guralnik
2024-09-06 5:35 ` [PATCH rdma-next 0/8] Introduce mlx5 Memory Scheme ODP Zhu Yanjun
2024-09-08 6:18 ` Michael Guralnik
2024-09-09 2:10 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904161839.GM3915968@nvidia.com \
--to=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.