From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>,
Tom Herbert <tom@herbertland.com>,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH net] ila: call nf_unregister_net_hooks() sooner
Date: Wed, 4 Sep 2024 19:38:51 +0200 [thread overview]
Message-ID: <20240904173851.GA24759@breakpoint.cc> (raw)
In-Reply-To: <20240904144418.1162839-1-edumazet@google.com>
Eric Dumazet <edumazet@google.com> wrote:
> syzbot found an use-after-free Read in ila_nf_input [1]
>
> Issue here is that ila_xlat_exit_net() frees the rhashtable,
> then call nf_unregister_net_hooks().
>
> It should be done in the reverse way, with a synchronize_rcu().
>
> This is a good match for a pre_exit() method.
Indeed, thanks Eric.
Reviewed-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2024-09-04 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 14:44 [PATCH net] ila: call nf_unregister_net_hooks() sooner Eric Dumazet
2024-09-04 17:38 ` Florian Westphal [this message]
2024-09-05 22:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240904173851.GA24759@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.