All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <jamie.bainbridge@gmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
	<joannelkoong@gmail.com>, <kuba@kernel.org>, <kuniyu@amazon.com>,
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<netdev@vger.kernel.org>, <pabeni@redhat.com>, <shuah@kernel.org>
Subject: Re: [PATCH net] selftests: net: enable bind tests
Date: Wed, 4 Sep 2024 10:45:33 -0700	[thread overview]
Message-ID: <20240904174533.8070-1-kuniyu@amazon.com> (raw)
In-Reply-To: <5a009b26cf5fb1ad1512d89c61b37e2fac702323.1725430322.git.jamie.bainbridge@gmail.com>

From: Jamie Bainbridge <jamie.bainbridge@gmail.com>
Date: Wed,  4 Sep 2024 16:12:26 +1000
> bind_wildcard is compiled but not run, bind_timewait is not compiled.
> 
> These two tests complete in a very short time, use the test harness
> properly, and seem reasonable to enable.
> 
> The author of the tests confirmed via email that these were
> intended to be run.
> 
> Enable these two tests.
> 
> Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.")
> Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.")
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>

Thanks!


> ---
>  tools/testing/selftests/net/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 8eaffd7a641c5d6bb5c63e3015fdd9f32c114550..9d5aa817411b653ac130a1a581d933180a597ce5 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -85,7 +85,8 @@ TEST_GEN_PROGS += so_incoming_cpu
>  TEST_PROGS += sctp_vrf.sh
>  TEST_GEN_FILES += sctp_hello
>  TEST_GEN_FILES += ip_local_port_range
> -TEST_GEN_FILES += bind_wildcard
> +TEST_GEN_PROGS += bind_wildcard
> +TEST_GEN_PROGS += bind_timewait
>  TEST_PROGS += test_vxlan_mdb.sh
>  TEST_PROGS += test_bridge_neigh_suppress.sh
>  TEST_PROGS += test_vxlan_nolocalbypass.sh
> -- 
> 2.39.2
> 

  parent reply	other threads:[~2024-09-04 17:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04  6:12 [PATCH net] selftests: net: enable bind tests Jamie Bainbridge
2024-09-04 13:06 ` Eric Dumazet
2024-09-04 17:45 ` Kuniyuki Iwashima [this message]
2024-09-05 22:10 ` patchwork-bot+netdevbpf
2024-09-06 13:53 ` Matthieu Baerts (NGI0)
2024-09-06 13:58 ` [PATCH net v2] " Matthieu Baerts (NGI0)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240904174533.8070-1-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jamie.bainbridge@gmail.com \
    --cc=joannelkoong@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.