All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/1] gpiolib: cdev: use !mem_is_zero() instead of memchr_inv(s, 0, n)
Date: Thu, 5 Sep 2024 21:01:21 +0800	[thread overview]
Message-ID: <20240905130121.GA166185@rigel> (raw)
In-Reply-To: <172552177868.28435.4071190094207246356.b4-ty@linaro.org>

On Thu, Sep 05, 2024 at 09:36:20AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
>
> On Wed, 04 Sep 2024 12:07:43 +0300, Andy Shevchenko wrote:
> > Use the mem_is_zero() helper where possible.
> >
> >
>
> Applied, thanks!
>
> [1/1] gpiolib: cdev: use !mem_is_zero() instead of memchr_inv(s, 0, n)
>       commit: b1da870ba36b3f525aee9be35b2f08a1feec61a7
>

As per my other mail, mem_is_zero() is not defined in gpio/for-next yet.
So how does this work?

If I build for-next I get:

drivers/gpio/gpiolib-cdev.c: In function ‘gpio_v2_line_config_validate’:
drivers/gpio/gpiolib-cdev.c:1334:14: error: implicit declaration of function ‘mem_is_zero’; did you mean ‘xa_is_zero’? [-Werror=implicit-function-declaration]
 1334 |         if (!mem_is_zero(lc->padding, sizeof(lc->padding)))
      |              ^~~~~~~~~~~
      |              xa_is_zero


Cheers,
Kent.

  reply	other threads:[~2024-09-05 13:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04  9:07 [PATCH v1 1/1] gpiolib: cdev: use !mem_is_zero() instead of memchr_inv(s, 0, n) Andy Shevchenko
2024-09-05  1:15 ` Kent Gibson
2024-09-05  7:36 ` Bartosz Golaszewski
2024-09-05 13:01   ` Kent Gibson [this message]
2024-09-05 13:04     ` Bartosz Golaszewski
2024-09-05 13:19       ` Kent Gibson
2024-09-05 16:11       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240905130121.GA166185@rigel \
    --to=warthog618@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.