From: Simon Horman <horms@kernel.org>
To: edward.cree@amd.com
Cc: linux-net-drivers@amd.com, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com,
Edward Cree <ecree.xilinx@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] sfc: siena: rip out rss-context dead code
Date: Thu, 5 Sep 2024 14:56:36 +0100 [thread overview]
Message-ID: <20240905135636.GI1722938@kernel.org> (raw)
In-Reply-To: <20240904181156.1993666-1-edward.cree@amd.com>
On Wed, Sep 04, 2024 at 07:11:56PM +0100, edward.cree@amd.com wrote:
> From: Edward Cree <ecree.xilinx@gmail.com>
>
> Siena hardware does not support custom RSS contexts, but when the
> driver was forked from sfc.ko, some of the plumbing for them was
> copied across from the common code. Actually trying to use them
> would lead to EOPNOTSUPP as the relevant efx_nic_type methods were
> not populated.
> Remove this dead code from the Siena driver.
>
> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Thanks, this looks like a clean removal of dead code to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-05 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 18:11 [PATCH net-next] sfc: siena: rip out rss-context dead code edward.cree
2024-09-05 13:56 ` Simon Horman [this message]
2024-09-07 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905135636.GI1722938@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=kuba@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.