From: Stefan Hajnoczi <stefanha@redhat.com>
To: Max Gurtovoy <mgurtovoy@nvidia.com>
Cc: virtualization@lists.linux.dev, mst@redhat.com,
Miklos Szeredi <mszeredi@redhat.com>,
Vivek Goyal <vgoyal@redhat.com>,
kvm@vger.kernel.org, Jingbo Xu <jefflexu@linux.alibaba.com>,
pgootzen@nvidia.com, smalin@nvidia.com, larora@nvidia.com,
ialroy@nvidia.com, oren@nvidia.com, izach@nvidia.com
Subject: Re: [PATCH v1 1/2] virtio_fs: introduce virtio_fs_put_locked helper
Date: Thu, 5 Sep 2024 10:17:44 -0400 [thread overview]
Message-ID: <20240905141744.GB1922502@fedora> (raw)
In-Reply-To: <20240825130716.9506-1-mgurtovoy@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Sun, Aug 25, 2024 at 04:07:15PM +0300, Max Gurtovoy wrote:
> Introduce a new helper function virtio_fs_put_locked to encapsulate the
> common pattern of releasing a virtio_fs reference while holding a lock.
> The existing virtio_fs_put helper will be used to release a virtio_fs
> reference while not holding a lock.
>
> Also add an assertion in case the lock is not taken when it should.
>
> Reviewed-by: Idan Zach <izach@nvidia.com>
> Reviewed-by: Shai Malin <smalin@nvidia.com>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
> fs/fuse/virtio_fs.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-09-05 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 13:07 [PATCH v1 1/2] virtio_fs: introduce virtio_fs_put_locked helper Max Gurtovoy
2024-08-25 13:07 ` [PATCH v1 2/2] virtio_fs: add sysfs entries for queue information Max Gurtovoy
2024-09-05 12:12 ` Michael S. Tsirkin
2024-09-05 12:11 ` [PATCH v1 1/2] virtio_fs: introduce virtio_fs_put_locked helper Michael S. Tsirkin
2024-09-05 14:17 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905141744.GB1922502@fedora \
--to=stefanha@redhat.com \
--cc=ialroy@nvidia.com \
--cc=izach@nvidia.com \
--cc=jefflexu@linux.alibaba.com \
--cc=kvm@vger.kernel.org \
--cc=larora@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=mszeredi@redhat.com \
--cc=oren@nvidia.com \
--cc=pgootzen@nvidia.com \
--cc=smalin@nvidia.com \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.