All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
Cc: Christopher McCrory <chrismcc@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCHv2 1/2] package/perl-file-slurp: add host package
Date: Thu, 5 Sep 2024 21:18:15 +0200	[thread overview]
Message-ID: <20240905211815.530e91c9@windsurf> (raw)
In-Reply-To: <20240905172607.1322733-1-guillaume.chaye@zeetim.com>

Hello Guillaume,

Thanks for this v2. Some minor comments below.

On Thu,  5 Sep 2024 19:26:06 +0200
"Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote:

> Some project like efitools requires host version of this package to build properly.

As requested by Yann on your v1, please wrap your commit message to ~72
characters.

> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
> ---
>  package/perl-file-slurp/perl-file-slurp.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/perl-file-slurp/perl-file-slurp.mk b/package/perl-file-slurp/perl-file-slurp.mk
> index 0d4ab94034..910d50d3c4 100644
> --- a/package/perl-file-slurp/perl-file-slurp.mk
> +++ b/package/perl-file-slurp/perl-file-slurp.mk
> @@ -12,3 +12,4 @@ PERL_FILE_SLURP_LICENSE_FILES = README.md
>  PERL_FILE_SLURP_DISTNAME = File-Slurp
>  
>  $(eval $(perl-package))
> +$(eval $(host-perl-package))
> \ No newline at end of file

Please add a newline at the end of the file, as suggested here by Git :-)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-09-05 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 17:26 [Buildroot] [PATCHv2 1/2] package/perl-file-slurp: add host package Guillaume GC. Chaye
2024-09-05 17:26 ` [Buildroot] [PATCHv2 2/2] package/efitools: efitools is a set of utilities to manipulate efi variables Guillaume GC. Chaye
2024-09-05 19:23   ` Thomas Petazzoni via buildroot
2024-09-05 19:18 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240905211815.530e91c9@windsurf \
    --to=buildroot@buildroot.org \
    --cc=chrismcc@gmail.com \
    --cc=guillaume.chaye@zeetim.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.