From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
michael.chan@broadcom.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] bnxt_en: implement tcp-data-split ethtool command
Date: Fri, 6 Sep 2024 18:38:44 -0700 [thread overview]
Message-ID: <20240906183844.2e8226f3@kernel.org> (raw)
In-Reply-To: <20240906080750.1068983-1-ap420073@gmail.com>
On Fri, 6 Sep 2024 08:07:48 +0000 Taehee Yoo wrote:
> The approach of this patch is to support the bnxt_en driver setting up
> enable/disable HDS explicitly, not rely on LRO/GRO, JUMBO.
> In addition, hds_threshold no longer follows rx-copybreak.
> By this patch, hds_threshold always be 0.
That may make sense for zero-copy use cases, where you want to make
sure that all of the data lands in target page pool. But in general
using the data buffers may waste quite a bit of memory, and PCIe bus
bandwidth (two small transfers instead of one medium size).
I think we should add a user-controlled setting in ethtool -g for
hds-threshold.
Also please make sure you describe the level of testing you have done
in the commit message. I remember discussing this a few years back
and at that time HDS was tied to GRO for bnxt at the FW level.
A lot has changed since but please describe what you tested..
--
pw-bot: cr
next prev parent reply other threads:[~2024-09-07 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 8:07 [PATCH net-next 0/2] bnxt_en: implement tcp-data-split ethtool command Taehee Yoo
2024-09-06 8:07 ` [PATCH net-next 1/2] bnxt_en: add support for rx-copybreak " Taehee Yoo
2024-09-06 8:07 ` [PATCH net-next 2/2] bnxt_en: add support for tcp-data-split " Taehee Yoo
2024-09-07 1:38 ` Jakub Kicinski [this message]
2024-09-07 17:06 ` [PATCH net-next 0/2] bnxt_en: implement " Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240906183844.2e8226f3@kernel.org \
--to=kuba@kernel.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.