Re: [PATCH v5 2/2] usb: misc: onboard_usb_dev: add Microchip usb5744 SMBus programming support

[kernel test robot <lkp@intel.com>]

Hi Radhey,

kernel test robot noticed the following build warnings:

[auto build test WARNING on b831f83e40a24f07c8dcba5be408d93beedc820f]

url:    https://github.com/intel-lab-lkp/linux/commits/Radhey-Shyam-Pandey/usb-misc-onboard_dev-extend-platform-data-to-add-power-on-delay-field/20240906-190218
base:   b831f83e40a24f07c8dcba5be408d93beedc820f
patch link:    https://lore.kernel.org/r/1725620423-1758964-3-git-send-email-radhey.shyam.pandey%40amd.com
patch subject: [PATCH v5 2/2] usb: misc: onboard_usb_dev: add Microchip usb5744 SMBus programming support
config: alpha-randconfig-r131-20240907 (https://download.01.org/0day-ci/archive/20240908/202409080045.SSIeS90P-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce: (https://download.01.org/0day-ci/archive/20240908/202409080045.SSIeS90P-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409080045.SSIeS90P-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/usb/misc/onboard_usb_dev.c: In function 'onboard_dev_5744_i2c_init':
>> drivers/usb/misc/onboard_usb_dev.c:347:1: warning: no return statement in function returning non-void [-Wreturn-type]
     347 | }
         | ^


vim +347 drivers/usb/misc/onboard_usb_dev.c

   311	
   312	static int onboard_dev_5744_i2c_init(struct i2c_client *client)
   313	{
   314	#if IS_ENABLED(CONFIG_I2C)
   315		struct device *dev = &client->dev;
   316		int ret;
   317	
   318		/*
   319		 * Set BYPASS_UDC_SUSPEND bit to ensure MCU is always enabled
   320		 * and ready to respond to SMBus runtime commands.
   321		 * The command writes 5 bytes to memory and single data byte in
   322		 * configuration register.
   323		 */
   324		char wr_buf[7] = {USB5744_CREG_MEM_ADDR, 5,
   325				  USB5744_CREG_WRITE, 1,
   326				  USB5744_CREG_RUNTIMEFLAGS2,
   327				  USB5744_CREG_RUNTIMEFLAGS2_LSB,
   328				  USB5744_CREG_BYPASS_UDC_SUSPEND};
   329	
   330		ret = i2c_smbus_write_block_data(client, 0, sizeof(wr_buf), wr_buf);
   331		if (ret)
   332			return dev_err_probe(dev, ret, "BYPASS_UDC_SUSPEND bit configuration failed\n");
   333	
   334		ret = i2c_smbus_write_word_data(client, USB5744_CMD_CREG_ACCESS,
   335						USB5744_CMD_CREG_ACCESS_LSB);
   336		if (ret)
   337			return dev_err_probe(dev, ret, "Configuration Register Access Command failed\n");
   338	
   339		/* Send SMBus command to boot hub. */
   340		ret = i2c_smbus_write_word_data(client, USB5744_CMD_ATTACH,
   341						USB5744_CMD_ATTACH_LSB);
   342		if (ret < 0)
   343			return dev_err_probe(dev, ret, "USB Attach with SMBus command failed\n");
   344	
   345		return ret;
   346	#endif
 > 347	}
   348	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki