All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: David Howells <dhowells@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [dhowells-fs:ceph-iter 43/61] drivers/block/rbd.c:2745:10: warning: #warning needs fixing
Date: Sun, 8 Sep 2024 04:36:48 +0800	[thread overview]
Message-ID: <202409080413.q0t3UIld-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git ceph-iter
head:   6c59f154a1d493b31755ac17326124d804172fb2
commit: 7c05d26d256ee374483db177836b744874562f1b [43/61] [INCOMPLETE] rbd: Switch from using bvec_iter to iov_iter
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240908/202409080413.q0t3UIld-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240908/202409080413.q0t3UIld-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409080413.q0t3UIld-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/block/rbd.c: In function 'rbd_obj_read_from_parent':
>> drivers/block/rbd.c:2745:10: warning: #warning needs fixing [-Wcpp]
    2745 |         #warning needs fixing
         |          ^~~~~~~


vim +2745 drivers/block/rbd.c

  2709	
  2710	static int rbd_obj_read_from_parent(struct rbd_obj_request *obj_req)
  2711	{
  2712		struct rbd_img_request *img_req = obj_req->img_request;
  2713		struct rbd_device *parent = img_req->rbd_dev->parent;
  2714		struct rbd_img_request *child_img_req;
  2715		int ret;
  2716	
  2717		child_img_req = kmem_cache_alloc(rbd_img_request_cache, GFP_NOIO);
  2718		if (!child_img_req)
  2719			return -ENOMEM;
  2720	
  2721		rbd_img_request_init(child_img_req, parent, OBJ_OP_READ);
  2722		__set_bit(IMG_REQ_CHILD, &child_img_req->flags);
  2723		child_img_req->obj_request = obj_req;
  2724	
  2725		down_read(&parent->header_rwsem);
  2726		rbd_img_capture_header(child_img_req);
  2727		up_read(&parent->header_rwsem);
  2728	
  2729		dout("%s child_img_req %p for obj_req %p\n", __func__, child_img_req,
  2730		     obj_req);
  2731	
  2732	#if 0 //////////////////// TODO
  2733		if (!rbd_img_is_write(img_req)) {
  2734			ret = rbd_img_fill_request(child_img_req,
  2735						   obj_req->img_extents,
  2736						   obj_req->num_img_extents,
  2737						   &obj_req->iter);
  2738		} else {
  2739			ret = rbd_img_fill_request(img_req,
  2740						   obj_req->img_extents,
  2741						   obj_req->num_img_extents,
  2742						   &obj_req->copyup_buf->iter);
  2743		}
  2744	#else
> 2745		#warning needs fixing
  2746		ret = -ENOMEM;
  2747		BUG();
  2748	#endif
  2749		if (ret) {
  2750			rbd_img_request_destroy(child_img_req);
  2751			return ret;
  2752		}
  2753	
  2754		/* avoid parent chain recursion */
  2755		rbd_img_schedule(child_img_req, 0);
  2756		return 0;
  2757	}
  2758	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-09-07 20:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202409080413.q0t3UIld-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dhowells@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.