From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A94F9E6FE49 for ; Mon, 9 Sep 2024 07:17:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3544910E2F4; Mon, 9 Sep 2024 07:17:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HZtBrN4Z"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CEB810E274; Sun, 8 Sep 2024 12:59:52 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 18D9D5C4186; Sun, 8 Sep 2024 12:59:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9AEEC4CEC3; Sun, 8 Sep 2024 12:59:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1725800391; bh=YhbRXnQ7EvIla3z4/eYbiKI7JBI6Gs+gMj9L+GFh4sg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HZtBrN4ZrhaOMUqXBEWM6rYfy6dMhWXi5azbVVRiVwlh1Zbw43h9BiJOw72ZRrakL 772lKjiq+5QmvD52Xb/VaXt8yg07ykkGHgUXT0sSy1AcCntIIgRUHZVgMucm8CcYL8 Gqby4C6UQTM9gKycY8/qiwJumLsxImwofGL5+RCk= Date: Sun, 8 Sep 2024 14:59:48 +0200 From: Greg KH To: Alex Deucher Cc: Mukul Sikka , stable@vger.kernel.org, evan.quan@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, Jun.Ma2@amd.com, kevinyang.wang@amd.com, sashal@kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vasavi.sirnapalli@broadcom.com, Bob Zhou , Tim Huang Subject: Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr Message-ID: <2024090829-mutt-remold-6d2c@gregkh> References: <20240903045809.5025-1-mukul.sikka@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailman-Approved-At: Mon, 09 Sep 2024 07:17:37 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Sep 06, 2024 at 11:02:32AM -0400, Alex Deucher wrote: > On Fri, Sep 6, 2024 at 4:50 AM Mukul Sikka wrote: > > > > On Fri, Sep 6, 2024 at 12:05 AM Alex Deucher wrote: > > > > > > On Tue, Sep 3, 2024 at 5:53 AM sikkamukul wrote: > > > > > > > > From: Bob Zhou > > > > > > > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] > > > > > > > > Check return value and conduct null pointer handling to avoid null pointer dereference. > > > > > > > > Signed-off-by: Bob Zhou > > > > Reviewed-by: Tim Huang > > > > Signed-off-by: Alex Deucher > > > > Signed-off-by: Sasha Levin > > > > Signed-off-by: Mukul Sikka > > > > > > Just out of curiosity, are you actually seeing an issue? This and a > > > lot of the other recent NULL check patches are just static checker > > > fixes. They don't actually fix a known issue. > > > > > No, according to the description of this patch and CVE-2024-43905. > > It seems to be applicable to LTS. > > I don't know that this is really CVE material, but oh well. I'm not > sure if it's actually possible to hit this in practice. If it's not possible, there's no need to add the check. thanks, greg k-h