Re: [PATCH net-next 2/3] bnxt_en: Add MSIX check in bnxt_check_rings()

[Simon Horman <horms@kernel.org>]

On Mon, Sep 09, 2024 at 01:27:36PM -0700, Michael Chan wrote:
> bnxt_check_rings() is called to ensure that we have the hardware ring
> resources before committing to reinitialize with the new number of
> rings.  MSIX vectors are never checked at this point, because up
> until recently we must first disable MSIX before we can allocate the
> new set of MSIX vectors.
> 
> Now that we support dynamic MSIX allocation, check to make sure we
> can dynamically allocate the new MSIX vectors as the last step in
> bnxt_check_rings() if dynamic MSIX is supported.
> 
> For example, the IOMMU group may limit the number of MSIX vectors
> for the device.  With this patch, the ring change will fail more
> gracefully when there is not enough MSIX vectors.
> 
> It is also better to move bnxt_check_rings() to be called as the last
> step when changing ethtool rings.
> 
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>

Reviewed-by: Simon Horman <horms@kernel.org>