All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Yu Jiaoliang <yujiaoliang@vivo.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Mustafa Ismail <mustafa.ismail@intel.com>,
	Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
	Erick Archer <erick.archer@gmx.com>,
	Akiva Goldberger <agoldberger@nvidia.com>,
	Patrisious Haddad <phaddad@nvidia.com>,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	Or Har-Toov <ohartoov@nvidia.com>,
	Rohit Chavan <roheetchavan@gmail.com>,
	Shigeru Yoshida <syoshida@redhat.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	opensource.kernel@vivo.com
Subject: Re: [PATCH v2 rdma-next] RDMA: Use ERR_CAST to return an error-valued pointer
Date: Tue, 10 Sep 2024 15:23:45 +0300	[thread overview]
Message-ID: <20240910122345.GZ4026@unreal> (raw)
In-Reply-To: <20240906062141.1845816-1-yujiaoliang@vivo.com>

On Fri, Sep 06, 2024 at 02:21:36PM +0800, Yu Jiaoliang wrote:
> Instead of directly casting and returning an error-valued pointer,
> use ERR_CAST to make the error handling more explicit and improve
> code clarity.
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
> ---
> v2:
> - Additional modifications in file /drivers/infiniband/hw/irdma/verbs.c
> v1: https://lore.kernel.org/all/20240905110615.GU4026@unreal/
> ---
>  drivers/infiniband/core/mad_rmpp.c   | 2 +-
>  drivers/infiniband/core/uverbs_cmd.c | 2 +-
>  drivers/infiniband/core/verbs.c      | 2 +-
>  drivers/infiniband/hw/irdma/verbs.c  | 4 ++--
>  4 files changed, 5 insertions(+), 5 deletions(-)

It is still incomplete.
Something like that will give you a better result:
➜  kernel git:(wip/leon-for-next) git grep "return (" drivers/infiniband/ | grep "\*"

Thanks

      reply	other threads:[~2024-09-10 12:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06  6:21 [PATCH v2 rdma-next] RDMA: Use ERR_CAST to return an error-valued pointer Yu Jiaoliang
2024-09-10 12:23 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910122345.GZ4026@unreal \
    --to=leon@kernel.org \
    --cc=agoldberger@nvidia.com \
    --cc=erick.archer@gmx.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mgurtovoy@nvidia.com \
    --cc=mustafa.ismail@intel.com \
    --cc=ohartoov@nvidia.com \
    --cc=opensource.kernel@vivo.com \
    --cc=phaddad@nvidia.com \
    --cc=roheetchavan@gmail.com \
    --cc=syoshida@redhat.com \
    --cc=tatyana.e.nikolova@intel.com \
    --cc=yujiaoliang@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.