All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Mathias Nyman <mathias.nyman@intel.com>
Cc: linux-usb@vger.kernel.org
Subject: [PATCH 0/2] Fix sum_trb_lengths()
Date: Tue, 10 Sep 2024 16:01:14 +0200	[thread overview]
Message-ID: <20240910160114.50b77a91@foxbook> (raw)

Hi,

This function sums from ring->dequeue instead of td->first_trb, and
this is even documented. Makes no sense and doesn't work right.

I searched xhci-ring.c and this appears to be the last such abuse of
'dequeue' still surviving to this day.

Regards,
Michal

             reply	other threads:[~2024-09-10 14:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-10 14:01 Michal Pecio [this message]
2024-09-10 14:02 ` [PATCH 1/2] usb: xhci: Remove unused parameters of next_trb() Michal Pecio
2024-09-10 14:03 ` [PATCH 2/2] usb: xhci: Fix sum_trb_lengths() Michal Pecio
2024-09-11 15:48 ` [PATCH 0/2] " Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240910160114.50b77a91@foxbook \
    --to=michal.pecio@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.