From: Jakub Kicinski <kuba@kernel.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Jeongjun Park <aha310510@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, ricardo@marliere.net, m-karicheri2@ti.com,
n.zhandarovich@fintech.ru, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+02a42d9b1bd395cbcab4@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: hsr: prevent NULL pointer dereference in hsr_proxy_announce()
Date: Tue, 10 Sep 2024 19:15:17 -0700 [thread overview]
Message-ID: <20240910191517.0eeaa132@kernel.org> (raw)
In-Reply-To: <20240909105822.16362339@wsk>
On Mon, 9 Sep 2024 10:58:22 +0200 Lukasz Majewski wrote:
> > In the function hsr_proxy_annouance() added in the previous commit
> > 5f703ce5c981 ("net: hsr: Send supervisory frames to HSR network
> > with ProxyNodeTable data"), the return value of the
> > hsr_port_get_hsr() function is not checked to be a NULL pointer,
> > which causes a NULL pointer dereference.
>
> Thank you for your patch.
>
> The code in hsr_proxy_announcement() is _only_ executed (the timer is
> configured to trigger this function) when hsr->redbox is set, which
> means that somebody has called earlier iproute2 command:
>
> ip link add name hsr1 type hsr slave1 lan4 slave2 lan5 interlink lan3
> supervision 45 version 1
Are you trying to say the patch is correct or incorrect?
The structs have no refcounting - should the timers be deleted with
_sync() inside hsr_check_announce()?
next prev parent reply other threads:[~2024-09-11 2:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 19:03 [PATCH net] net: hsr: prevent NULL pointer dereference in hsr_proxy_announce() Jeongjun Park
2024-09-09 8:40 ` Simon Horman
2024-09-09 8:58 ` Lukasz Majewski
2024-09-11 2:15 ` Jakub Kicinski [this message]
2024-09-11 8:00 ` Lukasz Majewski
2024-09-11 8:21 ` Simon Horman
2024-09-11 14:43 ` Jakub Kicinski
2024-09-11 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910191517.0eeaa132@kernel.org \
--to=kuba@kernel.org \
--cc=aha310510@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=m-karicheri2@ti.com \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo@marliere.net \
--cc=syzbot+02a42d9b1bd395cbcab4@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.