From: Stephen Hemminger <stephen@networkplumber.org>
To: Atlas Yu <atlas.yu@canonical.com>
Cc: kuba@kernel.org, edumazet@google.com, davem@davemloft.net,
pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net v1] dev_ioctl: fix the type of ifr_flags
Date: Tue, 10 Sep 2024 20:56:42 -0700 [thread overview]
Message-ID: <20240910205642.2d4a64ca@hermes.local> (raw)
In-Reply-To: <20240911034608.43192-1-atlas.yu@canonical.com>
On Wed, 11 Sep 2024 11:46:08 +0800
Atlas Yu <atlas.yu@canonical.com> wrote:
> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h
> index 797ba2c1562a..b612b6cd7446 100644
> --- a/include/uapi/linux/if.h
> +++ b/include/uapi/linux/if.h
> @@ -244,7 +244,7 @@ struct ifreq {
> struct sockaddr ifru_broadaddr;
> struct sockaddr ifru_netmask;
> struct sockaddr ifru_hwaddr;
> - short ifru_flags;
> + unsigned int ifru_flags;
> int ifru_ivalue;
> int ifru_mtu;
> struct ifmap ifru_map;
NAK
This breaks userspace ABI. There is no guarantee that
older application correctly zeros the upper flag bits.
next prev parent reply other threads:[~2024-09-11 3:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 3:46 [PATCH net v1] dev_ioctl: fix the type of ifr_flags Atlas Yu
2024-09-11 3:56 ` Stephen Hemminger [this message]
2024-09-11 4:20 ` Atlas Yu
[not found] ` <CAB55eyUZ=D-vnQZNaNEvLu6gVp33OXvsjJMmdeMiYqVR1FJ2XQ@mail.gmail.com>
2024-09-11 5:00 ` Stephen Hemminger
2024-09-11 7:21 ` Eric Dumazet
2024-09-11 8:30 ` Atlas Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240910205642.2d4a64ca@hermes.local \
--to=stephen@networkplumber.org \
--cc=atlas.yu@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.