From: "Michael S. Tsirkin" <mst@redhat.com>
To: Darren Kenny <darren.kenny@oracle.com>
Cc: "Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
virtualization@lists.linux.dev,
"Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
netdev@vger.kernel.org, "Si-Wei Liu" <si-wei.liu@oracle.com>
Subject: Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"
Date: Wed, 11 Sep 2024 10:22:32 -0400 [thread overview]
Message-ID: <20240911102106-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <m2ed5qnui8.fsf@oracle.com>
Thanks a lot!
Could you retest Xuan Zhuo original patch just to make sure it does
not fix the issue?
On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote:
> For the record, I got a chance to test these changes and confirmed that
> they resolved the issue for me when applied on 6.11-rc7.
>
> Tested-by: Darren Kenny <darren.kenny@oracle.com>
>
> Thanks,
>
> Darren.
>
> PS - I'll try get to looking at the other potential fix when I have time.
>
> On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote:
> > On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> >> Regression: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com
> >>
> >> I still think that the patch can fix the problem, I hope Darren can re-test it
> >> or give me more info.
> >>
> >> http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com
> >>
> >> If that can not work or Darren can not reply in time, Michael you can try this
> >> patch set.
> >
> > Just making sure netdev maintainers see this, this patch is for net.
> >
> >> Thanks.
> >>
> >> Xuan Zhuo (3):
> >> Revert "virtio_net: rx remove premapped failover code"
> >> Revert "virtio_net: big mode skip the unmap check"
> >> virtio_net: disable premapped mode by default
> >>
> >> drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
> >> 1 file changed, 46 insertions(+), 49 deletions(-)
> >>
> >> --
> >> 2.32.0.3.g01195cf9f
next prev parent reply other threads:[~2024-09-11 14:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 12:31 [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default" Xuan Zhuo
2024-09-06 12:31 ` [PATCH 1/3] Revert "virtio_net: rx remove premapped failover code" Xuan Zhuo
2024-09-06 12:31 ` [PATCH 2/3] Revert "virtio_net: big mode skip the unmap check" Xuan Zhuo
2024-09-06 12:31 ` [PATCH 3/3] virtio_net: disable premapped mode by default Xuan Zhuo
2024-09-08 19:38 ` [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default" Michael S. Tsirkin
2024-09-10 12:12 ` Michael S. Tsirkin
2024-09-10 16:03 ` Jakub Kicinski
2024-09-11 14:18 ` Darren Kenny
2024-09-11 14:22 ` Michael S. Tsirkin [this message]
2024-09-11 19:30 ` Si-Wei Liu
2024-09-12 1:49 ` Xuan Zhuo
2024-09-10 16:50 ` patchwork-bot+netdevbpf
2024-10-09 9:29 ` Michael S. Tsirkin
2024-10-09 10:00 ` Xuan Zhuo
2024-10-09 10:23 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911102106-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.