From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA5B114F104; Wed, 11 Sep 2024 13:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726060165; cv=none; b=RmyO+s99nLaPF/GUw6fpxOfWuCBuPR2iQxcg/OjKQWzbMhq9uuycMRIlHuuVFCydad9OxikGY0yHQDqj1DT2iWy5na7ZvGORWT2VGqifMJhQkMD3ygifZ4TDKj69kwNexoxY02qFg/O+u+1XTXGc5EnuWniuCthTmOceW/1ZZQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726060165; c=relaxed/simple; bh=pqqUGk1D8djsYTib86Sls8LSpZd+MZ1QOyXOw5DqIJA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aa0yLYppWInHvWZNO0XL72nAl7QvQvhbSRQWfli5Dkx+SqmY9uMsFrZhdENV5oEZCjS3IKln87EGfUgkhlCgPp+ZL8rXZqHzUiWb/0dUfFljYr22Ag+KohwX5obH4VFdF2nkHuQZ2lEjMoS6GTrJXZ3yliHtfFLbNxHp1FJdadw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iMMTqnRB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iMMTqnRB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C924C4CEC5; Wed, 11 Sep 2024 13:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726060165; bh=pqqUGk1D8djsYTib86Sls8LSpZd+MZ1QOyXOw5DqIJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iMMTqnRBBfmwKRtkYYMLYqi/eP13lsajhVtNVTYNOEWvb6/gnh8n5cSYOIA2yOStP Fr3KrYGfUmnitNZOdzl+gZu40k1PR7hWxnvmKVejrH3LiSBmsFY2Zb8kKYqJSZBCYR cEnSvAHHt7mGak51EkuM1Bxtm/lB0lmIxFNX8ATc= Date: Wed, 11 Sep 2024 15:09:22 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: Ruihai Zhou , kernel-janitors@vger.kernel.org, Markus Schneider-Pargmann , Srinivas Kandagatla , LKML Subject: Re: [PATCH] nvmem: core: Fix memleak in nvmem_add_cells_from_dt error path Message-ID: <2024091112-emotion-unspoken-1d48@gregkh> References: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Sep 11, 2024 at 03:05:20PM +0200, Markus Elfring wrote: > … > > is outside of the valid range, the info.name alloc by kasprintf will > > allocated by kasprintf()? > > > > cause memleak. Just free before return from nvmem_add_cells_from_dt > … > > a memory leak? ()? > > > How do you think about to increase the application of scope-based resource management? > > Regards, > Markus Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot