From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Richard W.M. Jones" <rjones@redhat.com>
Subject: [PULL 04/17] tests/unit: remove block layer code from test-nested-aio-poll
Date: Wed, 11 Sep 2024 14:33:29 +0200 [thread overview]
Message-ID: <20240911123342.339482-5-pbonzini@redhat.com> (raw)
In-Reply-To: <20240911123342.339482-1-pbonzini@redhat.com>
GCC is reporting a NULL pointer dereference when compiling aio_wait_kick()
with LTO.
The issue is that test-nested-aio-poll.c does not call qemu_init_main_loop().
It doesn't _need_ to because it never calls AIO_WAIT_WHILE(), but it seems
that LTO does not do enough dead-code elimination to catch that.
Fortunately aio_wait_kick() is only used in few places, and only in block
layer or system emulation code; and this test only needs the core event loop
functionality. It does not even need iothreads. So remove everything that
calls aio_wait_kick(), which is nice for coverage compared to adding the call
to qemu_init_main_loop().
Reported-by: Richard W.M. Jones <rjones@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2434
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/unit/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/unit/meson.build b/tests/unit/meson.build
index 490ab8182dc..6c377917636 100644
--- a/tests/unit/meson.build
+++ b/tests/unit/meson.build
@@ -115,7 +115,7 @@ if have_block
if host_os != 'windows'
tests += {
'test-image-locking': [testblock],
- 'test-nested-aio-poll': [testblock],
+ 'test-nested-aio-poll': [],
}
endif
if config_host_data.get('CONFIG_REPLICATION')
--
2.46.0
next prev parent reply other threads:[~2024-09-11 12:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 12:33 [PULL 00/17] Misc patches for 2024-09-11 Paolo Bonzini
2024-09-11 12:33 ` [PULL 01/17] target/i386: Delete duplicated macro definition CR4_FRED_MASK Paolo Bonzini
2024-09-11 12:33 ` [PULL 02/17] target/i386: Add VMX control bits for nested FRED support Paolo Bonzini
2024-09-11 12:33 ` [PULL 03/17] target/i386: Raise the highest index value used for any VMCS encoding Paolo Bonzini
2024-09-11 12:33 ` Paolo Bonzini [this message]
2024-09-11 12:33 ` [PULL 05/17] hw/i386/pc: Add a description for the i8042 property Paolo Bonzini
2024-09-11 12:33 ` [PULL 06/17] kvm/i386: make kvm_filter_msr() and related definitions private to kvm module Paolo Bonzini
2024-09-11 12:33 ` [PULL 07/17] kvm/i386: fix return values of is_host_cpu_intel() Paolo Bonzini
2024-09-11 12:33 ` [PULL 08/17] kvm: replace fprintf with error_report()/printf() in kvm_init() Paolo Bonzini
2024-09-11 12:33 ` [PULL 09/17] kvm/i386: refactor kvm_arch_init and split it into smaller functions Paolo Bonzini
2024-09-11 12:33 ` [PULL 10/17] kvm/i386: replace identity_base variable with a constant Paolo Bonzini
2024-09-11 12:33 ` [PULL 11/17] kvm: refactor core virtual machine creation into its own function Paolo Bonzini
2024-09-11 12:33 ` [PULL 12/17] target/i386: Expose IBPB-BRTYPE and SBPB CPUID bits to the guest Paolo Bonzini
2024-09-11 12:33 ` [PULL 13/17] hw: Remove unused inclusion of hw/char/serial.h Paolo Bonzini
2024-09-11 12:33 ` [PULL 14/17] hw/char/serial.h: Extract serial-isa.h Paolo Bonzini
2024-09-11 12:33 ` [PULL 15/17] hw/char: Extract serial-mm Paolo Bonzini
2024-09-11 12:33 ` [PULL 16/17] virtio-9p: remove virtfs-proxy-helper Paolo Bonzini
2024-09-11 12:57 ` Christian Schoenebeck via
2024-09-11 15:31 ` Paolo Bonzini
2024-09-11 12:33 ` [PULL 17/17] minikconf: print error entirely on stderr Paolo Bonzini
2024-09-12 15:17 ` [PULL 00/17] Misc patches for 2024-09-11 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911123342.339482-5-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.