From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Roman Kisel <romank@linux.microsoft.com>,
akpm@linux-foundation.org, apais@microsoft.com,
benhill@microsoft.com, ebiederm@xmission.com,
linux-kernel@vger.kernel.org, ssengar@microsoft.com,
sunilmut@microsoft.com, vdso@hexbites.dev,
workingjubilee@gmail.com
Subject: Re: [PATCH 1/1] ptrace: Get tracer PID without reliance on the proc FS
Date: Wed, 11 Sep 2024 22:14:02 +0200 [thread overview]
Message-ID: <20240911201402.GB16757@redhat.com> (raw)
In-Reply-To: <CAHk-=wjhqn+B85OA8pfLhckUXSwLtJzFq5JPO2cNNzhPN__HJQ@mail.gmail.com>
On 09/11, Linus Torvalds wrote:
>
> On Wed, 11 Sept 2024 at 12:54, Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > - please try to make your changelog more convincing. And in particular,
> > please explain why !!current->ptrace is not enough and this feature
> > needs the tracer's pid.
>
> Oleg, I realize you like the simpler patch that only has that
^^^^^^^^
No, no, I don't!!! ;)
> "!!current->ptrace", but my point is that even that simpler patch is
> simply WRONG, WRONG, WRONG.
and I agree, agree, agree.
> There is simply no valid situation where a "I have a tracer" is a good
> thing to test for.
Yes, yes, and that is why I added you/Eric to this discussion.
I just tried to play fair. I just thought that I can't simply "nack" this
change, because I can't explain why I didn't like the whole idea.
Oleg.
next prev parent reply other threads:[~2024-09-11 20:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 8:45 [PATCH 1/1] ptrace: Get tracer PID without reliance on the proc FS Jubilee Young
2024-09-09 19:37 ` Oleg Nesterov
2024-09-10 15:40 ` Roman Kisel
2024-09-11 14:44 ` Oleg Nesterov
2024-09-11 17:41 ` Roman Kisel
2024-09-11 19:53 ` Oleg Nesterov
2024-09-11 19:57 ` Linus Torvalds
2024-09-11 20:14 ` Oleg Nesterov [this message]
2024-09-11 20:25 ` Roman Kisel
2024-09-10 16:34 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2024-09-05 21:27 [PATCH 0/1] " Roman Kisel
2024-09-05 21:27 ` [PATCH 1/1] ptrace: " Roman Kisel
2024-09-06 11:24 ` Oleg Nesterov
2024-09-06 11:48 ` Oleg Nesterov
2024-09-06 19:09 ` Linus Torvalds
2024-09-06 20:08 ` Roman Kisel
2024-09-06 20:26 ` Linus Torvalds
2024-09-06 21:15 ` Roman Kisel
2024-09-09 16:18 ` Eric W. Biederman
2024-09-09 17:05 ` Oleg Nesterov
2024-09-09 17:34 ` Eric W. Biederman
2024-09-09 17:22 ` Roman Kisel
2024-09-06 20:55 ` Oleg Nesterov
2024-09-06 21:25 ` Roman Kisel
2024-09-08 14:08 ` Oleg Nesterov
2024-09-09 15:19 ` Roman Kisel
2024-09-09 16:42 ` Oleg Nesterov
2024-09-09 17:05 ` Roman Kisel
2024-09-07 19:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240911201402.GB16757@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apais@microsoft.com \
--cc=benhill@microsoft.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romank@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=sunilmut@microsoft.com \
--cc=torvalds@linux-foundation.org \
--cc=vdso@hexbites.dev \
--cc=workingjubilee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.