From: Boris Brezillon <boris.brezillon@collabora.com>
To: Steven Price <steven.price@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>,
dri-devel@lists.freedesktop.org,
Christopher Healy <healych@amazon.com>
Subject: Re: [PATCH v2] drm/panthor: Display FW version information
Date: Thu, 12 Sep 2024 09:34:01 +0200 [thread overview]
Message-ID: <20240912093401.348229bf@collabora.com> (raw)
In-Reply-To: <20240906094025.638173-1-steven.price@arm.com>
On Fri, 6 Sep 2024 10:40:25 +0100
Steven Price <steven.price@arm.com> wrote:
> The version number output when loading the firmware is actually the
> interface version not the version of the firmware itself. Update the
> message to make this clearer.
>
> However, the firmware binary has a git SHA embedded into it which can be
> used to identify which firmware binary is being loaded. So output this
> as a drm_info() so that it's obvious from a dmesg log which firmware
> binary is being used.
>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> Signed-off-by: Steven Price <steven.price@arm.com>
Queued to drm-misc-next.
Thanks!
Boris
prev parent reply other threads:[~2024-09-12 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:40 [PATCH v2] drm/panthor: Display FW version information Steven Price
2024-09-06 17:16 ` Healy, Christopher
2024-09-09 14:01 ` Carsten Haitzler
2024-09-09 14:14 ` Thomas Zimmermann
2024-09-09 14:47 ` Boris Brezillon
2024-09-12 7:34 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240912093401.348229bf@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=healych@amazon.com \
--cc=liviu.dudau@arm.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.