From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78DCF19F424; Thu, 12 Sep 2024 12:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726145638; cv=none; b=jfeFSL6d7p6gYdsEUZBpsg9yFxmne0tJdl0uujd6XakBT2Tww1KCNqscWjOgqMcUcpP37wWjbb2Wx10Y1W4k4b70P6fwEdjXkpd0GgDIO680b2Oikpl6LxB6xr17O4GEn8AB07eeTZ1oAZK22nDh3Ew7/G0h6JOAoOHuDP3oJEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726145638; c=relaxed/simple; bh=vIKfxdpXoZ/XNeIbpIk/mUSnEFEaryGhqrhIpPs460c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yu9JFUSEdD/21IzjPmzg8Aq2dRZ33vwHqJHabpqkoDfXIohlA8blYD0/Ugzndytkhq7vkoQ51Kl/G9cH7XaRaSq9x18wYgIX8iq3sNFSoZijy1jkOfdMjXql5WTV7HRx8S3RoYRyxBnaMcQry7gesOn/938ECB+Kt5gChGu6hbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 1096E227AAF; Thu, 12 Sep 2024 14:53:48 +0200 (CEST) Date: Thu, 12 Sep 2024 14:53:47 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jaegeuk@kernel.org, jlayton@kernel.org, chuck.lever@oracle.com, bvanassche@acm.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, gost.dev@samsung.com, vishak.g@samsung.com, javier.gonz@samsung.com Subject: Re: [PATCH v5 1/5] fs, block: refactor enum rw_hint Message-ID: <20240912125347.GA28068@lst.de> References: <20240910150200.6589-1-joshi.k@samsung.com> <20240910150200.6589-2-joshi.k@samsung.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240910150200.6589-2-joshi.k@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Sep 10, 2024 at 08:31:56PM +0530, Kanchan Joshi wrote: > Rename enum rw_hint to rw_lifetime_hint. > Change i_write_hint (in inode), bi_write_hint(in bio), and write_hint > (in request) to use u8 data-type rather than this enum. > > This is in preparation to introduce a new write hint type. The rationale seems a bit sparse. Why is it renamed? Because the name fits better, because you need the same for something else? > static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, > - enum rw_hint hint, struct writeback_control *wbc); > + u8 hint, struct writeback_control *wbc); And moving from the enum to an plain integer seems like a bit of a retrograde step. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5558DEED602 for ; Thu, 12 Sep 2024 13:13:22 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sojdS-0004K7-J5; Thu, 12 Sep 2024 13:13:22 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sojdR-0004K0-9Q for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Sep 2024 13:13:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8ha6rW27ZIti3ibXL0Tfok2s62J7TAoIUJwlpmmHK2s=; b=mWnw+vFRAdGAGvod6EtbfvERCV G4ut2UR7twNdETS3ALAkQFqHnd5+z6NM2DFskD/H0T9ChFlQpzCcJyDO24QSnQUOU8KofF1Gn9mV/ S18qxfLZifMCyA9pLfzr0pxGt9Rm6yt5DcfPSygNRekjBknOeh4GAk8/O6VMF3qB8xRE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8ha6rW27ZIti3ibXL0Tfok2s62J7TAoIUJwlpmmHK2s=; b=hSS/odKBHb70wpsyPJT1OCcu+S EPQwKMMBzyiBv3A6TpLu84QL1NEwPtTHY5vmTf7351+hKe6VeTNoneJBlWGjE2OjJGwzawhuVcVyG NYRSu/54WVrILNvxs2y63Xd6eTfbAsY4coH0HHs2KlgHb2KVhFZGM0k7DG+nVZOugQOY=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sojdP-0007jc-VW for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Sep 2024 13:13:20 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 1096E227AAF; Thu, 12 Sep 2024 14:53:48 +0200 (CEST) Date: Thu, 12 Sep 2024 14:53:47 +0200 From: Christoph Hellwig To: Kanchan Joshi Message-ID: <20240912125347.GA28068@lst.de> References: <20240910150200.6589-1-joshi.k@samsung.com> <20240910150200.6589-2-joshi.k@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240910150200.6589-2-joshi.k@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1sojdP-0007jc-VW Subject: Re: [f2fs-dev] [PATCH v5 1/5] fs, block: refactor enum rw_hint X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, brauner@kernel.org, jack@suse.cz, sagi@grimberg.me, martin.petersen@oracle.com, gost.dev@samsung.com, jlayton@kernel.org, vishak.g@samsung.com, linux-nvme@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net, James.Bottomley@HansenPartnership.com, linux-fsdevel@vger.kernel.org, chuck.lever@oracle.com, javier.gonz@samsung.com, viro@zeniv.linux.org.uk, linux-scsi@vger.kernel.org, kbusch@kernel.org, jaegeuk@kernel.org, hch@lst.de, bvanassche@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Sep 10, 2024 at 08:31:56PM +0530, Kanchan Joshi wrote: > Rename enum rw_hint to rw_lifetime_hint. > Change i_write_hint (in inode), bi_write_hint(in bio), and write_hint > (in request) to use u8 data-type rather than this enum. > > This is in preparation to introduce a new write hint type. The rationale seems a bit sparse. Why is it renamed? Because the name fits better, because you need the same for something else? > static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, > - enum rw_hint hint, struct writeback_control *wbc); > + u8 hint, struct writeback_control *wbc); And moving from the enum to an plain integer seems like a bit of a retrograde step. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel