All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Yu Liao <liaoyu15@huawei.com>
Cc: davem@davemloft.net, xiexiuqi@huawei.com, netdev@vger.kernel.org,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next] net: hsr: convert to use new timer API
Date: Fri, 13 Sep 2024 09:26:37 +0100	[thread overview]
Message-ID: <20240913082637.GS572255@kernel.org> (raw)
In-Reply-To: <20240912033912.1019563-1-liaoyu15@huawei.com>

On Thu, Sep 12, 2024 at 11:39:12AM +0800, Yu Liao wrote:
> del_timer_sync() has been renamed to timer_delete_sync(). Inconsistent
> API usage makes the code a bit confusing, so replace with the new API.
> 
> No functional changes intended.
> 
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>

Thanks, I agree that it is currently inconsistent.
And that this patch addresses all relevant calls in this function.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2024-09-13  8:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12  3:39 [PATCH net-next] net: hsr: convert to use new timer API Yu Liao
2024-09-13  8:26 ` Simon Horman [this message]
2024-09-15 17:20 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913082637.GS572255@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=liaoyu15@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.