From: Jakub Kicinski <kuba@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>,
Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL_GRXRINGS ioctl
Date: Fri, 13 Sep 2024 13:34:26 -0700 [thread overview]
Message-ID: <20240913133426.0f7df2b3@kernel.org> (raw)
In-Reply-To: <20240913093828.2549217-1-vladimir.oltean@nxp.com>
On Fri, 13 Sep 2024 12:38:28 +0300 Vladimir Oltean wrote:
> Several drivers regressed when ethtool --show-rxfh was converted from
> ioctl to netlink. This is because ETHTOOL_GRXRINGS was converted to
> ETHTOOL_MSG_CHANNELS_GET, which is semantically equivalent to
> ETHTOOL_GCHANNELS but different from ETHTOOL_GRXRINGS. Drivers which
> implement ETHTOOL_GRXRINGS do not necessarily implement ETHTOOL_GCHANNELS
> or its netlink equivalent.
>
> According to the man page, "A channel is an IRQ and the set of queues
> that can trigger that IRQ.", which is different from the definition of
> a queue/ring. So we shouldn't be attempting to query the # of rings for
> the ioctl variant, but the # of channels for the netlink variant anyway.
>
> Reimplement the args->num_rings retrieval as in do_grxfh(), aka using
> the ETHTOOL_GRXRINGS ioctl.
Acked-by: Jakub Kicinski <kuba@kernel.org>
Thanks for fixing this! Not sure why Sudheer didn't.
next prev parent reply other threads:[~2024-09-13 20:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 9:38 [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL_GRXRINGS ioctl Vladimir Oltean
2024-09-13 20:34 ` Jakub Kicinski [this message]
2024-09-13 22:43 ` Mogilappagari, Sudheer
2024-09-13 22:45 ` Mogilappagari, Sudheer
2024-09-13 22:48 ` Vladimir Oltean
2024-09-13 23:07 ` Mogilappagari, Sudheer
2024-09-19 17:58 ` Jacob Keller
2024-10-03 9:18 ` Vladimir Oltean
2024-10-03 11:09 ` Michal Kubecek
2024-10-03 13:49 ` Vladimir Oltean
2024-10-03 23:20 ` Michal Kubecek
2024-10-04 19:19 ` Keller, Jacob E
2024-10-05 7:46 ` Michal Kubecek
2024-10-07 22:12 ` Jacob Keller
2024-09-16 19:38 ` Michal Kubecek
2024-09-17 15:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913133426.0f7df2b3@kernel.org \
--to=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sudheer.mogilappagari@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.