From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Phil Sutter <phil@nwl.cc>,
Antonio Ojea <antonio.ojea.garcia@gmail.com>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_tproxy: make it terminal
Date: Fri, 13 Sep 2024 16:18:04 +0200 [thread overview]
Message-ID: <20240913141804.GA22091@breakpoint.cc> (raw)
In-Reply-To: <ZuQx3_x6JJgzA0gS@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Hmm. Looking at nft_nat.c, 'accept' seems consistent with what nat
> > statements do implicitly.
>
> Yes, and xt_TPROXY does NF_ACCEPT.
>
> On the other hand, I can see it does NF_DROP it socket is not
> transparent, it does NFT_BREAK instead, so policy keeps evaluating the
> packet.
Yes, this is more flexible since you can log+drop for instance in next
rule(s) to alert that proxy isn't running for example.
> > > is this sufficient in your opinion? If so, I made this quick update
> > > for man nft(8).
> >
> > Acked-by: Phil Sutter <phil@nwl.cc>
> >
> > In addition to that, I will update tproxy_tg_xlate() in iptables.git to
> > emit a verdict, too.
>
> Thanks, this is very convenient.
Agreed, it should append accept keyword in the translator.
next prev parent reply other threads:[~2024-09-13 14:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 10:20 [PATCH nf] netfilter: nft_tproxy: make it terminal Pablo Neira Ayuso
2024-09-13 10:23 ` Florian Westphal
2024-09-13 10:28 ` Pablo Neira Ayuso
2024-09-13 10:29 ` Pablo Neira Ayuso
2024-09-13 10:41 ` Florian Westphal
2024-09-13 10:47 ` Pablo Neira Ayuso
2024-09-13 11:02 ` Antonio Ojea
2024-09-13 11:24 ` Pablo Neira Ayuso
2024-09-13 12:00 ` Phil Sutter
2024-09-13 12:36 ` Pablo Neira Ayuso
2024-09-13 14:18 ` Florian Westphal [this message]
2024-09-13 15:38 ` Antonio Ojea
2024-09-13 20:35 ` Phil Sutter
2024-09-16 10:37 ` Antonio Ojea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913141804.GA22091@breakpoint.cc \
--to=fw@strlen.de \
--cc=antonio.ojea.garcia@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.