All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
	"Mahesh J Salgaonkar" <mahesh@linux.ibm.com>,
	"Oliver O'Halloran" <oohall@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	linux-kernel@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v6 3/8] PCI: Make pcie_read_tlp_log() signature same
Date: Fri, 13 Sep 2024 17:36:27 +0300	[thread overview]
Message-ID: <20240913143632.5277-4-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20240913143632.5277-1-ilpo.jarvinen@linux.intel.com>

pcie_read_tlp_log()'s prototype and function signature diverged due to
changes made while applying.

Make the parameters of pcie_read_tlp_log() named identically.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/pci/pcie/tlp.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/pcie/tlp.c b/drivers/pci/pcie/tlp.c
index 3f053cc62290..2bf15749cd31 100644
--- a/drivers/pci/pcie/tlp.c
+++ b/drivers/pci/pcie/tlp.c
@@ -15,22 +15,21 @@
  * pcie_read_tlp_log - read TLP Header Log
  * @dev: PCIe device
  * @where: PCI Config offset of TLP Header Log
- * @tlp_log: TLP Log structure to fill
+ * @log: TLP Log structure to fill
  *
- * Fill @tlp_log from TLP Header Log registers, e.g., AER or DPC.
+ * Fill @log from TLP Header Log registers, e.g., AER or DPC.
  *
  * Return: 0 on success and filled TLP Log structure, <0 on error.
  */
 int pcie_read_tlp_log(struct pci_dev *dev, int where,
-		      struct pcie_tlp_log *tlp_log)
+		      struct pcie_tlp_log *log)
 {
 	int i, ret;
 
-	memset(tlp_log, 0, sizeof(*tlp_log));
+	memset(log, 0, sizeof(*log));
 
 	for (i = 0; i < 4; i++) {
-		ret = pci_read_config_dword(dev, where + i * 4,
-					    &tlp_log->dw[i]);
+		ret = pci_read_config_dword(dev, where + i * 4, &log->dw[i]);
 		if (ret)
 			return pcibios_err_to_errno(ret);
 	}
-- 
2.39.2


  parent reply	other threads:[~2024-09-13 14:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-13 14:36 [PATCH v6 0/8] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-09-13 14:36 ` [PATCH v6 1/8] PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem Ilpo Järvinen
2024-12-11 16:22   ` Jonathan Cameron
2024-09-13 14:36 ` [PATCH v6 2/8] PCI: Move TLP Log handling to own file Ilpo Järvinen
2024-12-11 16:25   ` Jonathan Cameron
2024-09-13 14:36 ` Ilpo Järvinen [this message]
2024-12-11 16:26   ` [PATCH v6 3/8] PCI: Make pcie_read_tlp_log() signature same Jonathan Cameron
2024-09-13 14:36 ` [PATCH v6 4/8] PCI: Use unsigned int i in pcie_read_tlp_log() Ilpo Järvinen
2024-12-11 16:58   ` Jonathan Cameron
2024-09-13 14:36 ` [PATCH v6 5/8] PCI: Store # of supported End-End TLP Prefixes Ilpo Järvinen
2024-12-11 16:36   ` Jonathan Cameron
2024-12-12 18:03     ` Ilpo Järvinen
2024-09-13 14:36 ` [PATCH v6 6/8] PCI: Add TLP Prefix reading into pcie_read_tlp_log() Ilpo Järvinen
2024-12-11 16:49   ` Jonathan Cameron
2024-12-12 16:12     ` Ilpo Järvinen
2024-12-12 18:48       ` Ilpo Järvinen
2024-12-13 15:54         ` Jonathan Cameron
2024-09-13 14:36 ` [PATCH v6 7/8] PCI: Create helper to print TLP Header and Prefix Log Ilpo Järvinen
2024-12-11 16:56   ` Jonathan Cameron
2024-09-13 14:36 ` [PATCH v6 8/8] PCI/AER: Add prefixes to printouts Ilpo Järvinen
2024-12-11 16:58   ` Jonathan Cameron
2024-10-23  8:27 ` [PATCH v6 0/8] PCI: Consolidate TLP Log reading and printing Ilpo Järvinen
2024-12-10 18:19   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240913143632.5277-4-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lukas@wunner.de \
    --cc=mahesh@linux.ibm.com \
    --cc=oohall@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.