From: Jakub Kicinski <kuba@kernel.org>
To: "Krzysztof Olędzki" <ole@ans.pl>
Cc: Ido Schimmel <idosch@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Yishai Hadas <yishaih@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] mlx4/mlx5: {mlx4,mlx5e}_en_get_module_info cleanup
Date: Fri, 13 Sep 2024 19:48:08 -0700 [thread overview]
Message-ID: <20240913194808.43932def@kernel.org> (raw)
In-Reply-To: <6b979753-9f5a-410c-9fe3-d2366976e316@ans.pl>
On Fri, 13 Sep 2024 19:12:01 -0700 Krzysztof Olędzki wrote:
> On 13.09.2024 at 13:55, Jakub Kicinski wrote:
> > On Wed, 11 Sep 2024 23:38:45 -0700 Krzysztof Olędzki wrote:
> >> Use SFF8024 constants defined in linux/sfp.h instead of private ones.
> >>
> >> Make mlx4_en_get_module_info() and mlx5e_get_module_info() to look
> >> as close as possible to each other.
> >>
> >> Simplify the logic for selecting SFF_8436 vs SFF_8636.
> >
> > Minor process suggestion, I think you may be sending the patches one by
> > one. It's best to format them into a new directory and send all at once
> > with git send-email. Add a cover letter, too.
> >
>
> Thanks, yes, will do for v2. I assume this needs to wait for about
> two weeks for net-next to re-open?
The cleanups - yes, but if patch 3 works you should make it independent
and send as a fix (and trees never close for fixes).
next prev parent reply other threads:[~2024-09-14 2:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 6:38 [PATCH net-next 1/4] mlx4/mlx5: {mlx4,mlx5e}_en_get_module_info cleanup Krzysztof Olędzki
2024-09-13 20:55 ` Jakub Kicinski
2024-09-14 2:12 ` Krzysztof Olędzki
2024-09-14 2:48 ` Jakub Kicinski [this message]
2024-09-14 8:21 ` Simon Horman
2024-09-15 2:21 ` Krzysztof Olędzki
2024-09-16 9:38 ` Przemek Kitszel
2024-09-16 7:16 ` Gal Pressman
2024-09-16 7:30 ` Krzysztof Olędzki
2024-09-16 8:44 ` Gal Pressman
2024-09-17 4:19 ` Krzysztof Olędzki
2024-09-17 7:04 ` Gal Pressman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240913194808.43932def@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ole@ans.pl \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.