Re: [Buildroot] [PATCH 2/2] package/qt6/qt6tools: enable QML support in linguist

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Hitz via buildroot <buildroot@buildroot.org>
Cc: Christian Hitz <christian@klarinett.li>,
	Christian Hitz <christian.hitz@bbv.ch>,
	Jesse Van Gavere <jesseevg@gmail.com>,
	Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/qt6/qt6tools: enable QML support in linguist
Date: Sat, 14 Sep 2024 12:56:50 +0200	[thread overview]
Message-ID: <20240914125650.6afe0bdd@windsurf> (raw)
In-Reply-To: <20240911132021.2318073-2-christian@klarinett.li>

Hello Christian,

On Wed, 11 Sep 2024 15:20:20 +0200
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:

> From: Christian Hitz <christian.hitz@bbv.ch>
> 
> When BR2_PACKAGE_QT6DECLARATIVE_QUICK is enabled the qt linuguist tool
> lupdate should support QML/JS files.
> 
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> ---
>  package/qt6/qt6tools/qt6tools.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied, but after adjusting to:

@@ -49,6 +49,12 @@ HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
 
 ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS),y)
 HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
+# When we have qt6declarative for the target, we need to build the
+# linguist tool with host-qt6declarative support so that it handles
+# QML/JS files
+ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
+HOST_QT6TOOLS_DEPENDENCIES += host-qt6declarative
+endif
 else
 HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=OFF
 endif

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
