Re: [Buildroot] [PATCH 1/1] package/ffmpeg: fix build error

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale <thomas.perale@essensium.com>
Cc: Anisse Astier <anisse@astier.eu>,
	Thomas Perale <thomas.perale@mind.be>,
	Christian Stewart <christian@aperture.us>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/ffmpeg: fix build error
Date: Sat, 14 Sep 2024 18:23:22 +0200	[thread overview]
Message-ID: <20240914182322.181c10d5@windsurf> (raw)
In-Reply-To: <20240914153651.2633469-1-thomas.perale@mind.be>

Hello Thomas,

On Sat, 14 Sep 2024 17:36:51 +0200
Thomas Perale <thomas.perale@essensium.com> wrote:

> ffmpeg builds with `--enable-vaapi` opt made GCC v14 and 32 bit target
> will throw an 'Wincompatible-pointer-types' error.
> 
> This is a downport of an upstreamed commit but not yet present in any
> ffmpeg version that fix the pointer type.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/f5f/f5f2d16226ad9500ecf046779d5282ee071a54d3/
> 
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>

Thanks for your patch!

> diff --git a/package/ffmpeg/0007-avutil-hwcontext-vaapi-use-the-correct-type.patch b/package/ffmpeg/0007-avutil-hwcontext-vaapi-use-the-correct-type.patch
> new file mode 100644
> index 0000000000..e455654b2e
> --- /dev/null
> +++ b/package/ffmpeg/0007-avutil-hwcontext-vaapi-use-the-correct-type.patch
> @@ -0,0 +1,26 @@
> +From 6f8e365a2af2b6b21701d41eed3b2e3f8a436eeb Mon Sep 17 00:00:00 2001
> +From: James Almer <jamrial@gmail.com>
> +Date: Wed, 31 Jul 2024 10:00:54 -0300
> +Subject: [PATCH] avutil/hwcontext_vaapi: use the correct type for
> + VASurfaceAttribExternalBuffers.buffers
> +
> +Should fix ticket #11115.
> +
> +Signed-off-by: James Almer <jamrial@gmail.com>

We need you to add your Signed-off-by line below the one of the
original author, and we need an Upstream: tag pointing to the upstream
commit (or pull request or mailing list submission if the fix isn't
applied upstream yet).

Note that those issues are reported by "make check-package". I suggest
that you add https://paste.ack.tf/faa8ee as your .git/hooks/post-commit
so that it automatically runs check-package on the changes you make.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot