All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-grpc-requests: bump to version 0.1.20
Date: Sun, 15 Sep 2024 10:35:09 +0200	[thread overview]
Message-ID: <20240915103509.477e03f5@windsurf> (raw)
In-Reply-To: <20240915073805.1552173-1-james.hilliard1@gmail.com>

Hello James,

On Sun, 15 Sep 2024 01:38:05 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Add new python-protobuf runtime dependency.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-grpc-requests/Config.in                 | 1 +
>  package/python-grpc-requests/python-grpc-requests.hash | 4 ++--
>  package/python-grpc-requests/python-grpc-requests.mk   | 4 ++--
>  3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/python-grpc-requests/Config.in b/package/python-grpc-requests/Config.in
> index 1cdd0d3f67..ad29617795 100644
> --- a/package/python-grpc-requests/Config.in
> +++ b/package/python-grpc-requests/Config.in
> @@ -7,6 +7,7 @@ config BR2_PACKAGE_PYTHON_GRPC_REQUESTS
>  	select BR2_PACKAGE_PYTHON_GOOGLE_API_CORE # runtime
>  	select BR2_PACKAGE_PYTHON_GRPCIO # runtime
>  	select BR2_PACKAGE_PYTHON_GRPCIO_REFLECTION # runtime
> +	select BR2_PACKAGE_PYTHON_PROTOBUF # runtime

You're adding a select, but not propagating the "depends on" of
BR2_PACKAGE_PYTHON_PROTOBUF. In this case, I have already done so as
part of your previous google-api-core bump, which selected
python-proto-plus, which selected python-protobuf, and therefore also
had this dependency. But if possible try to be careful when adding
select, and think about those dependencies.

So here, I have just updated the comment next to the
BR2_PACKAGE_HOST_PROTOBUF_ARCH_SUPPORTS depency:

-       depends on BR2_PACKAGE_HOST_PROTOBUF_ARCH_SUPPORTS # python-google-api-core
+       depends on BR2_PACKAGE_HOST_PROTOBUF_ARCH_SUPPORTS # python-google-api-core, python-protobuf

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-09-15  8:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15  7:38 [Buildroot] [PATCH 1/1] package/python-grpc-requests: bump to version 0.1.20 James Hilliard
2024-09-15  8:35 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240915103509.477e03f5@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.