All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH 1/1] package/libssh: fix build failure
Date: Sun, 15 Sep 2024 12:04:45 +0200	[thread overview]
Message-ID: <20240915120445.0d5154d0@windsurf> (raw)
In-Reply-To: <20240915093048.810466-1-thomas.perale@mind.be>

On Sun, 15 Sep 2024 11:30:48 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> When compiling libssh without a C++ cross-compiler the build will fail.
> 
> This patch remove the CMake C++ dependency to build libssh. That dependency
> is only used for the code coverage tool and is not required to build the
> library.
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/927/92794da6346b856ad74f14f87cc51415871cb5d2/
>   - http://autobuild.buildroot.org/results/89d/89dcd4982e4061732de635f9e7669db1f257330c/
>   - http://autobuild.buildroot.org/results/b3f/b3feff5c21defb53c65a3d5d06b13230cfed3317/
>   - http://autobuild.buildroot.org/results/bc8/bc8338d2c61eaa7c98c99140de5c491b7528c4f3/
>   - ...
> 
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
>  ...enable-CXX-when-running-the-coverage.patch | 57 +++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 package/libssh/0001-cmake-Only-enable-CXX-when-running-the-coverage.patch

Thanks a lot, but once applied your patch doesn't apply to the libssh
code base:

>>> libssh 0.11.1 Patching

Applying 0001-cmake-Only-enable-CXX-when-running-the-coverage.patch using patch: 
patching file CMakeLists.txt
Hunk #1 FAILED at 9.
1 out of 2 hunks FAILED -- saving rejects to file CMakeLists.txt.rej
patching file cmake/Modules/AddCMockaTest.cmake
make: *** [package/pkg-generic.mk:247: /home/thomas/projets/buildroot/output/build/libssh-0.11.1/.stamp_patched] Error 1

Maybe you did your patch against libssh master, and forgot to rebase it
on top of 0.11.1 before adding it in Buildroot?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-09-15 10:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15  9:30 [Buildroot] [PATCH 1/1] package/libssh: fix build failure Thomas Perale via buildroot
2024-09-15 10:04 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240915120445.0d5154d0@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.