All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH 1/1 v2] package/libssh: fix build failure
Date: Sun, 15 Sep 2024 12:54:20 +0200	[thread overview]
Message-ID: <20240915125420.37622174@windsurf> (raw)
In-Reply-To: <20240915103629.884407-1-thomas.perale@mind.be>

On Sun, 15 Sep 2024 12:36:29 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/libssh/0001-cmake-Only-enable-CXX-when-running-the-coverage.patch b/package/libssh/0001-cmake-Only-enable-CXX-when-running-the-coverage.patch
> new file mode 100644
> index 0000000000..e70c0fa44e
> --- /dev/null
> +++ b/package/libssh/0001-cmake-Only-enable-CXX-when-running-the-coverage.patch
> @@ -0,0 +1,56 @@
> +From 328ae3d2306c9f65b5e85a2be98a368c07287a05 Mon Sep 17 00:00:00 2001
> +From: Thomas Perale <thomas.perale@mind.be>
> +Date: Sat, 14 Sep 2024 21:07:30 +0200
> +Subject: [PATCH] cmake: Only enable CXX when running the coverage
> +
> +Commit 25a678190c42b24076fdd805a8d7a722a8a9c798 introduced code coverage
> +collection. That also introduced a dependency to CXX language.
> +
> +When cross-compiling libssh in an environment that doesn't have a C++ compiler
> +the following error is raised: "No CMAKE_CXX_COMPILER could be found.".
> +
> +Since the C++ part is only needed for the coverage part, this commit only enable
> +that language dependency when actually needing it.
> +
> +Signed-off-by: Thomas Perale <thomas.perale@mind.be>

Then it was missing the Upstream: tag this time around, causing a
"check-package" issue. I fixed that up, and applied. You may want to
add https://paste.ack.tf/f908e5 as your .git/hooks/post-commit to get
nice check-package checking integrated in your Git workflow.

Thanks a lot for providing this fix!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-09-15 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15 10:36 [Buildroot] [PATCH 1/1 v2] package/libssh: fix build failure Thomas Perale via buildroot
2024-09-15 10:54 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240915125420.37622174@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.