Re: [Buildroot] [PATCH 1/1] package/lrzsz: bump to latest git commit

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/lrzsz: bump to latest git commit
Date: Sun, 15 Sep 2024 15:31:40 +0200	[thread overview]
Message-ID: <20240915153140.3a94ac39@windsurf> (raw)
In-Reply-To: <20240726092042.1273023-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Fri, 26 Jul 2024 11:20:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> - Switch to github to get latest code
> - LRZSZ_POST_EXTRACT_HOOKS must be added to remove wrong links on
>   /usr/share/automake-1.16/config.{guess,sub} which were added by
>   https://github.com/UweOhse/lrzsz/commit/f02af40d15bade4c07e057f4b3baccd341b692b6
> - timesync dropped by
>   https://github.com/UweOhse/lrzsz/commit/6322e4944c11373eeadc346e838351874b7d799f
> - This bump will also fix the following build failure with gcc >= 14:
> 
>   configure:1011:1: error: return type defaults to 'int' [-Wimplicit-int]
>    1011 | main(){return(0);}
>         | ^~~~
> 
>   [...]
> 
>   configure: error: installation or configuration problem: C compiler cannot create executables.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/076db37c936786291028b770ef2f83cd39f87ef3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...-lib-long-options-c-include-stdlib-h.patch | 41 +++++++++++++++++++
>  .../0002-configure.ac-check-locale.h.patch    | 31 ++++++++++++++
>  package/lrzsz/lrzsz.hash                      |  2 +-
>  package/lrzsz/lrzsz.mk                        | 13 ++++--
>  4 files changed, 83 insertions(+), 4 deletions(-)
>  create mode 100644 package/lrzsz/0001-lib-long-options-c-include-stdlib-h.patch
>  create mode 100644 package/lrzsz/0002-configure.ac-check-locale.h.patch

You provided no feedback to my questions asked in July, so I looked
again into this. Looking more, the maintainer on its Github repo says:

========================================================================

NOTE:

Do not use the repository until further notice.
It contains work in progress and at least one change i am unhappy with.

Use either http://ohse.de/uwe/testing/lrzsz-0.12.21rc.tar.gz (over 20
years in rc state, so it's good enough), or 0.12.20 from 
https://ohse.de/uwe/software/lrzsz.html (do not expect me to update 
that old site ever again).

========================================================================

So instead, I sent a small patch that doesn't bump the version, but
fixes the GCC >= 14.x issues:
https://patchwork.ozlabs.org/project/buildroot/patch/20240915132735.862622-1-thomas.petazzoni@bootlin.com/.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot