From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Hugo Cornelis via buildroot <buildroot@buildroot.org>
Cc: Hugo Cornelis <hugo.cornelis@essensium.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/ncurses: put headers in the common include directory.
Date: Sun, 15 Sep 2024 16:02:26 +0200 [thread overview]
Message-ID: <20240915160226.339b0d30@windsurf> (raw)
In-Reply-To: <20240915131934.1636336-1-hugo.cornelis@essensium.com>
On Sun, 15 Sep 2024 15:19:34 +0200
Hugo Cornelis via buildroot <buildroot@buildroot.org> wrote:
> When wide char is enabled in ncurses, packages such as procps-ng,
> expect ncurses.h in a 'cursesw' subdirectory. We have to disable
> ncurses overwriting header files in the regular directory.
>
> This fixes several builds running on the autobuilders (see below for a
> few examples) but not all of them. For examples this does not solve
> the similar but not the same build problem:
> http://autobuild.buildroot.org/results/e7665f43b97c6f90a7a8ce83eb16cfc364c3fc1a/
>
> Fixes:
> - http://autobuild.buildroot.org/results/72d8bf3e618ae7797f3311fbbdbd90d77dfed4ad/
> - http://autobuild.buildroot.org/results/809dac9945e24c7e0bb6cb37c38cb258b41b3276/
> - http://autobuild.buildroot.org/results/12b348238bd3ef8116ac48a35d0a9d18dad38f04/
> - http://autobuild.buildroot.org/results/f86546cc0934f44e0d1851a932d64d2d29790f17/
> - http://autobuild.buildroot.org/results/93ca9899542d4ef31f3609219e09ce1db8ba7cad/
> - http://autobuild.buildroot.org/results/901e5a5e394d6e0b67bff15946ece9d66398b73d/
> - http://autobuild.buildroot.org/results/10c23c9f5d79dcb8a68551a15009e9d1b3be1fff/
> - http://autobuild.buildroot.org/results/38e8aeb5469314f31c78506f62a714f57ff030d9/
> - http://autobuild.buildroot.org/results/9e09b7ba0c6213471c73ffc6cb3c777b4aa33b23/
> - http://autobuild.buildroot.org/results/82d747d0d6b7150cba0b921cc9431c0f5bdf86f7/
> Signed-off-by: Hugo Cornelis <hugo.cornelis@essensium.com>
Thanks for the research!
However, what is the impact of this change on other packages than
procps-ng, that currently build fine? Indeed if I understand your
change correctly, it means that the ncurses header files will be in a
different place... potentially breaking other packages, no?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-09-15 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 13:19 [Buildroot] [PATCH 1/1] package/ncurses: put headers in the common include directory Hugo Cornelis via buildroot
2024-09-15 14:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240915160226.339b0d30@windsurf \
--to=buildroot@buildroot.org \
--cc=hugo.cornelis@essensium.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.