From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7611C57BB for ; Sun, 15 Sep 2024 14:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726409270; cv=none; b=UuChQ6q6WKjoeETx3i9zXBYE4lOdnqFMIU7ctQeNwwDo3q76nSb87mmnMxT7iifyyTq+0+L7krP09AWscNhg0PHceyUDWfhg6m4+IU43cMGnwoWQp0BWTx4BQW7HsOHM/DMGAe+tdW8rYBZ35cfcf5Z5dfwHNIBX66hy9JAzAOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726409270; c=relaxed/simple; bh=xrNlX2cq5CAVWANS86NRFmvzIHBwfNTkanTtBmO7MPU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=HBxcIYn+VFSgsd/BX3gzdI5BS/71n4KDZPYxXREEx+kiPTh4X+sSnZ89pQYLht7NRQpC00AGMezTYleHGhWLatHEd8hyOlS1euAfn6daxagpvGuO4mxlTruNX0CEn5EzI/vo+FU5LfdKuZn+Gk1/reyCqF4yDilCIDDkmEBFXHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hSmWJ1y1; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hSmWJ1y1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1726409268; x=1757945268; h=date:from:to:cc:subject:message-id:mime-version; bh=xrNlX2cq5CAVWANS86NRFmvzIHBwfNTkanTtBmO7MPU=; b=hSmWJ1y1DiaT4NgkRJmppbfsA6aUMRhSr7idpRNGseygwG1hEcNh7zhE FY7NSeajhW16FmSCSgfGB7dONDt43ErL19wypFYCtQ29jSmn9/vIQSxsq x/CDtLPPnU252xr6idxp8zil/UKoUB1fnUeinVnSdP+FsHTTSOA+3xX8g tOcCbtCCaWgHX0875LdDz/KPPrnnYgJvrEE7m4w2LiioZtry0UuAXzN4n cM0ymKFZeVdhz7R1foGVa67xhFHEN0GNOlMHJkrkXRHeplVtwuE9jhFCA SKBw4zrA8xdPnQgaUv6OPzGRO9ah5sb1ScjCIYEM1UIJJaSjndGxoQNxW Q==; X-CSE-ConnectionGUID: fdoQHQJNRpmj00/hPYEgeg== X-CSE-MsgGUID: 1y1vH32gT8OebBkeXwrZeg== X-IronPort-AV: E=McAfee;i="6700,10204,11196"; a="42731500" X-IronPort-AV: E=Sophos;i="6.10,231,1719903600"; d="scan'208";a="42731500" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2024 07:07:47 -0700 X-CSE-ConnectionGUID: NEwVWFe5Tquo0E2pCN2dtA== X-CSE-MsgGUID: H5o6qsmiQ4mXt6qWA3FhvA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,231,1719903600"; d="scan'208";a="72724516" Received: from lkp-server01.sh.intel.com (HELO 53e96f405c61) ([10.239.97.150]) by fmviesa003.fm.intel.com with ESMTP; 15 Sep 2024 07:07:46 -0700 Received: from kbuild by 53e96f405c61 with local (Exim 4.96) (envelope-from ) id 1sppui-0008iy-0I; Sun, 15 Sep 2024 14:07:44 +0000 Date: Sun, 15 Sep 2024 22:07:27 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c:612 iwl_mvm_mld_start_ap_ibss() warn: missing error code 'ret' Message-ID: <202409160031.caQ4LNOA-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Johannes Berg CC: Miri Korenblit tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d42f7708e27cc68d080ac9d3803d27e86821d775 commit: 3f3126515fbee0e364f8218f6171c091d8e2555e wifi: iwlwifi: mvm: add mvm-specific guard date: 4 months ago :::::: branch date: 9 hours ago :::::: commit date: 4 months ago config: csky-randconfig-r073-20240915 (https://download.01.org/0day-ci/archive/20240916/202409160031.caQ4LNOA-lkp@intel.com/config) compiler: csky-linux-gcc (GCC) 14.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202409160031.caQ4LNOA-lkp@intel.com/ smatch warnings: drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c:612 iwl_mvm_mld_start_ap_ibss() warn: missing error code 'ret' vim +/ret +612 drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c bde2f9b420f692 Mukesh Sisodiya 2024-04-16 573 f947b62c03b15d Miri Korenblit 2023-03-20 574 static int iwl_mvm_mld_start_ap_ibss(struct ieee80211_hw *hw, cbce62a315f67e Miri Korenblit 2023-03-28 575 struct ieee80211_vif *vif, cbce62a315f67e Miri Korenblit 2023-03-28 576 struct ieee80211_bss_conf *link_conf) f947b62c03b15d Miri Korenblit 2023-03-20 577 { f947b62c03b15d Miri Korenblit 2023-03-20 578 struct iwl_mvm *mvm = IWL_MAC80211_GET_MVM(hw); f947b62c03b15d Miri Korenblit 2023-03-20 579 struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif); f947b62c03b15d Miri Korenblit 2023-03-20 580 int ret; f947b62c03b15d Miri Korenblit 2023-03-20 581 3f3126515fbee0 Johannes Berg 2024-05-12 582 guard(mvm)(mvm); bde2f9b420f692 Mukesh Sisodiya 2024-04-16 583 bde2f9b420f692 Mukesh Sisodiya 2024-04-16 584 if (vif->type == NL80211_IFTYPE_AP) bde2f9b420f692 Mukesh Sisodiya 2024-04-16 585 iwl_mvm_send_ap_tx_power_constraint_cmd(mvm, vif, link_conf); bde2f9b420f692 Mukesh Sisodiya 2024-04-16 586 36cf537798cb6c Gregory Greenman 2023-03-28 587 /* Send the beacon template */ 36cf537798cb6c Gregory Greenman 2023-03-28 588 ret = iwl_mvm_mac_ctxt_beacon_changed(mvm, vif, link_conf); 36cf537798cb6c Gregory Greenman 2023-03-28 589 if (ret) 3f3126515fbee0 Johannes Berg 2024-05-12 590 return ret; 36cf537798cb6c Gregory Greenman 2023-03-28 591 bf976c814c864e Johannes Berg 2023-03-28 592 /* the link should be already activated when assigning chan context */ bf976c814c864e Johannes Berg 2023-03-28 593 ret = iwl_mvm_link_changed(mvm, vif, link_conf, bf976c814c864e Johannes Berg 2023-03-28 594 LINK_CONTEXT_MODIFY_ALL & bf976c814c864e Johannes Berg 2023-03-28 595 ~LINK_CONTEXT_MODIFY_ACTIVE, f947b62c03b15d Miri Korenblit 2023-03-20 596 true); f947b62c03b15d Miri Korenblit 2023-03-20 597 if (ret) 3f3126515fbee0 Johannes Berg 2024-05-12 598 return ret; f947b62c03b15d Miri Korenblit 2023-03-20 599 62e0ccb2170e7a Gregory Greenman 2023-03-28 600 ret = iwl_mvm_mld_add_mcast_sta(mvm, vif, link_conf); f947b62c03b15d Miri Korenblit 2023-03-20 601 if (ret) 3f3126515fbee0 Johannes Berg 2024-05-12 602 return ret; f947b62c03b15d Miri Korenblit 2023-03-20 603 f947b62c03b15d Miri Korenblit 2023-03-20 604 /* Send the bcast station. At this stage the TBTT and DTIM time f947b62c03b15d Miri Korenblit 2023-03-20 605 * events are added and applied to the scheduler f947b62c03b15d Miri Korenblit 2023-03-20 606 */ 62e0ccb2170e7a Gregory Greenman 2023-03-28 607 ret = iwl_mvm_mld_add_bcast_sta(mvm, vif, link_conf); f947b62c03b15d Miri Korenblit 2023-03-20 608 if (ret) f947b62c03b15d Miri Korenblit 2023-03-20 609 goto out_rm_mcast; f947b62c03b15d Miri Korenblit 2023-03-20 610 f947b62c03b15d Miri Korenblit 2023-03-20 611 if (iwl_mvm_start_ap_ibss_common(hw, vif, &ret)) f947b62c03b15d Miri Korenblit 2023-03-20 @612 goto out_failed; f947b62c03b15d Miri Korenblit 2023-03-20 613 f947b62c03b15d Miri Korenblit 2023-03-20 614 /* Need to update the P2P Device MAC (only GO, IBSS is single vif) */ f947b62c03b15d Miri Korenblit 2023-03-20 615 if (vif->p2p && mvm->p2p_device_vif) f947b62c03b15d Miri Korenblit 2023-03-20 616 iwl_mvm_mld_mac_ctxt_changed(mvm, mvm->p2p_device_vif, false); f947b62c03b15d Miri Korenblit 2023-03-20 617 f947b62c03b15d Miri Korenblit 2023-03-20 618 iwl_mvm_bt_coex_vif_change(mvm); f947b62c03b15d Miri Korenblit 2023-03-20 619 f947b62c03b15d Miri Korenblit 2023-03-20 620 /* we don't support TDLS during DCM */ f947b62c03b15d Miri Korenblit 2023-03-20 621 if (iwl_mvm_phy_ctx_count(mvm) > 1) f947b62c03b15d Miri Korenblit 2023-03-20 622 iwl_mvm_teardown_tdls_peers(mvm); f947b62c03b15d Miri Korenblit 2023-03-20 623 fd940de72d493c Avraham Stern 2023-06-12 624 iwl_mvm_ftm_restart_responder(mvm, vif, link_conf); f947b62c03b15d Miri Korenblit 2023-03-20 625 3f3126515fbee0 Johannes Berg 2024-05-12 626 return 0; f947b62c03b15d Miri Korenblit 2023-03-20 627 f947b62c03b15d Miri Korenblit 2023-03-20 628 out_failed: f947b62c03b15d Miri Korenblit 2023-03-20 629 iwl_mvm_power_update_mac(mvm); f947b62c03b15d Miri Korenblit 2023-03-20 630 mvmvif->ap_ibss_active = false; 62e0ccb2170e7a Gregory Greenman 2023-03-28 631 iwl_mvm_mld_rm_bcast_sta(mvm, vif, link_conf); f947b62c03b15d Miri Korenblit 2023-03-20 632 out_rm_mcast: 62e0ccb2170e7a Gregory Greenman 2023-03-28 633 iwl_mvm_mld_rm_mcast_sta(mvm, vif, link_conf); f947b62c03b15d Miri Korenblit 2023-03-20 634 return ret; f947b62c03b15d Miri Korenblit 2023-03-20 635 } f947b62c03b15d Miri Korenblit 2023-03-20 636 :::::: The code at line 612 was first introduced by commit :::::: f947b62c03b15d14349668384bb365aabe898650 wifi: iwlwifi: mvm: add start_ap() and join_ibss() callbacks for MLD mode :::::: TO: Miri Korenblit :::::: CC: Johannes Berg -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki