From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5332CDD573 for ; Thu, 19 Sep 2024 13:15:41 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B9D65850; Thu, 19 Sep 2024 15:15:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B9D65850 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1726751739; bh=04M62AnevvKOpl+yrEWkhUipAMKBwSj5m1kfSIBHe7E=; h=From:To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=qa8A9hsIJp2dYrwb/J9u6jfVk53tSed+cPrdOwPzkFYv+f99GtTSVHQqZG4vfDO5Q v5zDCTgAkDmLBVsc/N0+240huYWHqvpXqpJGUXaT+OhBS8QjeWvRtfKwiQFdqw79Q4 FaKmo21AIq19F33hx1Vst2JpJ3wwYyyqLyzxyGDU= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2A383F806D9; Thu, 19 Sep 2024 15:13:25 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 45D2DF806D9; Thu, 19 Sep 2024 15:13:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F283F8020D; Mon, 16 Sep 2024 13:34:17 +0200 (CEST) Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A19FAF80107 for ; Mon, 16 Sep 2024 13:34:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A19FAF80107 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=microchip.com header.i=@microchip.com header.a=rsa-sha256 header.s=mchp header.b=YP0KVLnk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1726486456; x=1758022456; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=04M62AnevvKOpl+yrEWkhUipAMKBwSj5m1kfSIBHe7E=; b=YP0KVLnkfZmW5TS81gTX22hnn4EaCTDkjBlFe8oYkAgvBjRRe+kZ083i XsXYXXGD+ZIYi88tIZqNbfIyD35DKekA6PowM71fi6+Bg26iSPNqrCbFQ QwmyBPJltfH6K+x1N/QLa1hLmEOJmg4d+FkYAIv4abo9PNXsyHNThR4lV +UVp/0V0JUBCdjbx6TdK+1QMiMhkCgglGt63vvwwqjMHot6MDIR+eaKfF UfRGRKVzIe5RbRQy83qt7OCwAiwstifYTC91xkhYn2VjVGhXlTiIXdC86 1ufPRS+DerdU4/WyzTEjxJdwsjKqDj6LAHYPP9TRik0wTXlFfPWZuTrOM A==; X-CSE-ConnectionGUID: Onkqnjp3T4uu7VkYLySsmg== X-CSE-MsgGUID: DF5Odg+jTkKSP28grZCI6g== X-IronPort-AV: E=Sophos;i="6.10,233,1719903600"; d="scan'208";a="32447859" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2024 04:34:11 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 16 Sep 2024 04:34:05 -0700 Received: from ROB-ULT-M76677.microchip.com (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 16 Sep 2024 04:34:03 -0700 From: Andrei Simion To: CC: , , , , , , , , , , , Subject: Re: [PATCH 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Date: Mon, 16 Sep 2024 14:32:05 +0300 Message-ID: <20240916113203.17871-1-andrei.simion@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240916100006f2db7b06@mail.local> References: <20240916100006f2db7b06@mail.local> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MailFrom: prvs=98237714c=Andrei.Simion@microchip.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: 7VUQBQGSL3PMQD2NA2QFC77M4LHSQO2A X-Message-ID-Hash: 7VUQBQGSL3PMQD2NA2QFC77M4LHSQO2A X-Mailman-Approved-At: Thu, 19 Sep 2024 13:13:10 +0000 X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 16.09.2024 12:59, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 16/09/2024 11:52:15+0300, Andrei Simion wrote: >> From: Codrin Ciubotariu >> >> Drop S24_LE format because it is not supported if more than 2 channels >> (of TDM slots) are used. This limitation makes it impractical for use cases >> requiring more than 2 TDM slots, leading to potential issues in >> multi-channel configurations. >> >> [andrei.simion@microchip.com: Reword the commit title and the commit >> message.] >> >> Signed-off-by: Codrin Ciubotariu >> Signed-off-by: Andrei Simion >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index 7047f17fe7a8..475e7579c64c 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -822,7 +822,7 @@ static int atmel_ssc_resume(struct snd_soc_component *component) >> } >> >> #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ >> - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) >> + SNDRV_PCM_FMTBIT_S32_LE) > > I believe this requires a comment. Else someone may add it back later > on. > It is unclear to me. Would it be good to send v2 with this update? >> >> static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { >> .startup = atmel_ssc_startup, >> -- >> 2.34.1 >> > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Best regards, Andrei Simion From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C6E0C3ABA2 for ; Mon, 16 Sep 2024 11:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AV7CPyJvvlu7uA5NbRRPerH5jeo/t+UagoizsXp5u5k=; b=S7V61wEX8aoWDhL5UB+hTLTBwA jgp0DnbkxT18Bpo2dTNv9DSbZ2O13dNXywbb+g5kWybXDvJdRA3aHjugOKOnyJnvREUzCw89LDB1E mY9vldV2uGbzl2sjEAUNWZKwAo1rwIyiqlikd8wQyEMwd+xbEvqLAVL1vAk1lb8oiOyjMv1CwqC2p 4cVMXn1cR/UmTQC1LsKDnk6DXsoCs1wFSi1m2Z/kFtfKd25NV3H+Iqpp1j9JSfDYr10YftIq1I5iI dXUWWkZOfiLWTSFnn8dn/rUnEP2jCiY0Z+Suz2vtq7KTj53piF602flI3st7cO2YNideo4JsHXZxq YB5nTNFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sqA0n-00000003sxP-3s23; Mon, 16 Sep 2024 11:35:22 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sq9zh-00000003sg5-3llM for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2024 11:34:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1726486454; x=1758022454; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=04M62AnevvKOpl+yrEWkhUipAMKBwSj5m1kfSIBHe7E=; b=gaS/9G/6Zkfd5lcAOc02bf1PLNx7H3BxxzajFZPZ5+O6NhlC0ouuPtoZ aKu5Kam7giE29qI6VNeVyzhRFQv43yGN6fb7DH3IZlxNJDTWQ78rZxKRe 4JnKhvKE2Uds2o0XiH1ab214q/AsETE4uYpG6ePpMiZEd90eGoDOsWXB/ Zfdr7wofPH78UWw8MUsjVf2GznJT4BkE4BE+++T7OvprVZUFHmZMrDcGs U39WRhisRlQkyhJQBxR2/mPKEqFCLjO+t+Tdy9Y+vpnAiHsYCXjRSmOOr ItXNC7Kz/alaX2ZdpkFJRkr7fWtE30OYYFHf/rGwH+Y2k547vZt+ZmVZK g==; X-CSE-ConnectionGUID: Onkqnjp3T4uu7VkYLySsmg== X-CSE-MsgGUID: DF5Odg+jTkKSP28grZCI6g== X-IronPort-AV: E=Sophos;i="6.10,233,1719903600"; d="scan'208";a="32447859" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 16 Sep 2024 04:34:11 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 16 Sep 2024 04:34:05 -0700 Received: from ROB-ULT-M76677.microchip.com (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 16 Sep 2024 04:34:03 -0700 From: Andrei Simion To: Subject: Re: [PATCH 2/2] ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation Date: Mon, 16 Sep 2024 14:32:05 +0300 Message-ID: <20240916113203.17871-1-andrei.simion@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240916100006f2db7b06@mail.local> References: <20240916100006f2db7b06@mail.local> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240916_043414_141079_3403453C X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, claudiu.beznea@tuxon.dev, linux-sound@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, tiwai@suse.com, andrei.simion@microchip.com, codrin.ciubotariu@microchip.com, perex@perex.cz, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16.09.2024 12:59, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 16/09/2024 11:52:15+0300, Andrei Simion wrote: >> From: Codrin Ciubotariu >> >> Drop S24_LE format because it is not supported if more than 2 channels >> (of TDM slots) are used. This limitation makes it impractical for use cases >> requiring more than 2 TDM slots, leading to potential issues in >> multi-channel configurations. >> >> [andrei.simion@microchip.com: Reword the commit title and the commit >> message.] >> >> Signed-off-by: Codrin Ciubotariu >> Signed-off-by: Andrei Simion >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index 7047f17fe7a8..475e7579c64c 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -822,7 +822,7 @@ static int atmel_ssc_resume(struct snd_soc_component *component) >> } >> >> #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |\ >> - SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE) >> + SNDRV_PCM_FMTBIT_S32_LE) > > I believe this requires a comment. Else someone may add it back later > on. > It is unclear to me. Would it be good to send v2 with this update? >> >> static const struct snd_soc_dai_ops atmel_ssc_dai_ops = { >> .startup = atmel_ssc_startup, >> -- >> 2.34.1 >> > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Best regards, Andrei Simion