From: Simon Horman <horms@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Aring <alex.aring@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL
Date: Mon, 16 Sep 2024 20:04:16 +0100 [thread overview]
Message-ID: <20240916190416.GE396300@kernel.org> (raw)
In-Reply-To: <20240916205246-5df7e565-6950-4503-ac4d-741c37b1afda@linutronix.de>
On Mon, Sep 16, 2024 at 08:54:21PM +0200, Thomas Weißschuh wrote:
> On Mon, Sep 16, 2024 at 07:48:51PM GMT, Simon Horman wrote:
> > On Mon, Sep 16, 2024 at 07:44:43PM +0100, Simon Horman wrote:
> > > On Mon, Sep 16, 2024 at 06:53:15PM +0200, Thomas Weißschuh wrote:
> > > > The rpl sr tunnel code contains calls to dst_cache_*() which are
> > > > only present when the dst cache is built.
> > > > Select DST_CACHE to build the dst cache, similar to other kconfig
> > > > options in the same file.
> > > >
> > > > Fixes: a7a29f9c361f ("net: ipv6: add rpl sr tunnel")
> > > > Cc: stable@vger.kernel.org
> > > > ---
> > > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> > >
> > > Reviewed-by: Simon Horman <horms@kernel.org>
> > > Tested-by: Simon Horman <horms@kernel.org> # build-tested
> >
> > Sorry Thomas, I missed one important thing:
> >
> > Your Signed-off-by line needs to go above the scissors ('---')
> > because when git applies your patch nothing below the scissors
> > is included in the patch description.
>
> Welp, this seems to be due to a combination of me forgetting to add it,
> b4 adding it below the scissors automatically and then failing to warn
> about the missing sign-off.
>
> I'll resend v2 with your tags. And will also remove the Cc: stable as
> per net rules.
Thanks. Please be aware of the 24h rule.
https://docs.kernel.org/process/maintainer-netdev.html
next prev parent reply other threads:[~2024-09-16 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 16:53 [PATCH net] net: ipv6: select DST_CACHE from IPV6_RPL_LWTUNNEL Thomas Weißschuh
2024-09-16 18:44 ` Simon Horman
2024-09-16 18:48 ` Simon Horman
2024-09-16 18:54 ` Thomas Weißschuh
2024-09-16 19:04 ` Simon Horman [this message]
2024-09-16 19:05 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916190416.GE396300@kernel.org \
--to=horms@kernel.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.