From: Al Viro <viro@zeniv.linux.org.uk>
To: Daniel Yang <danielyangkang@gmail.com>
Cc: Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] fs/exfat: resolve memory leak from exfat_create_upcase_table()
Date: Mon, 16 Sep 2024 23:12:11 +0100 [thread overview]
Message-ID: <20240916221211.GC3107530@ZenIV> (raw)
In-Reply-To: <CAGiJo8SBf4zsY-ZrZQh_hxYZ7=xObfcgFxbTnWOtcz9DORGueA@mail.gmail.com>
On Mon, Sep 16, 2024 at 02:58:43PM -0700, Daniel Yang wrote:
> In exfat_create_upcase_table, ENOMEM and EINVAL result in a jump to
> exfat_load_default_upcase_table where memory is also allocated. Since
> ENOMEM doesn't allocate memory, freeing null addresses will result in a
> double free.
Freeing null address is a no-op. Explicitly guaranteed, for the
same reason why C standard guarantees that free(NULL) is a no-op.
So you don't need to check if allocation had been done.
prev parent reply other threads:[~2024-09-16 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 5:21 [PATCH v2] fs/exfat: resolve memory leak from exfat_create_upcase_table() Daniel Yang
2024-09-16 11:26 ` Namjae Jeon
[not found] ` <CAGiJo8SBf4zsY-ZrZQh_hxYZ7=xObfcgFxbTnWOtcz9DORGueA@mail.gmail.com>
2024-09-16 22:12 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916221211.GC3107530@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=danielyangkang@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=syzbot+e1c69cadec0f1a078e3d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.