From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6DA7C3ABCE for ; Mon, 16 Sep 2024 18:51:11 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4X6vBk0Qz9z307f for ; Tue, 17 Sep 2024 04:51:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2604:1380:4641:c500::1" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1726512665; cv=none; b=JFHqURGvXgEbB9lGYKZxlM6DOTV9BPkemH9ZnbK8gzc6EEIrdrd+/NaoIthcGFclSN0hO57VI5MSeefznRZHVC7PeqAfb48pfZt1yvH0IUgfbv5pqTF6yPZvGcdElgTcJImESRLBhq+amGIAwATq2ViNZGLDKrjVpkKQwNNvg0gmoiggBmBnPLB5WlT0IG7HrDOjXFTGrDTKQtK6bV9r2hyqoC2/CNN1/9MUVtxibzo61I2Qym1iO3of2oLQoLKsTM9+nDBm7Me0j8dfSW1B+O6kOcCfS9PhZoqXJqXGvU9hjUwtEdo4Rfz/vJe4ti5TwOfAN3Cv4smduGW/K2f5fg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1726512665; c=relaxed/relaxed; bh=LEbWnfJGJmKt+Yr5iWMNIIRlpA2VvaunAoOdVU7T1ZI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JmPr8biw53a5O8EdSpoaoqTWE64codaAO1NvjP1Bp34JjDsfdHmju7bUD5fVEBw5SnG/45CcwM3ycy6NPlRqh6wcHlp/beHTAQlTy7YOjTWa0L8AB60QbxL9ArjvUtQ8sGCNQ0K8Z76lZpg6bnv/s5PJUbs93RwkeFrJUzStBl6mmqYbR9Mk3wmgIn/RNSaEOUbnnMGPauHrvC95JILdTojC6b4g0+CayL2JOrmnPAbybYGE/btDxs2Tt7bmZYerJEVz+edR22yVq5zyn3jBnpEfJhasHZdw11B0Ky5SamSJXqacKZEofmuLP987O4C7LucGphH/D1izfY0jrfjd+g== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=VZub7Ckf; dkim-atps=neutral; spf=pass (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org) smtp.mailfrom=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=VZub7Ckf; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4X6vBc6mqFz2xjh for ; Tue, 17 Sep 2024 04:51:04 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2C9215C034A; Mon, 16 Sep 2024 18:50:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C5A3C4CEC4; Mon, 16 Sep 2024 18:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726512661; bh=kmvv0I4Ktqu9r1ximFiGLBL2DIIDeLyJoXWdA9l9kAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VZub7CkfnbGEVyQuEiC5+fKJkjCjtcPNanvKH5G9tdavMr+MyMgnhMoA6PmrH2O+5 fhV4BJDeKKXX8Qv0A95z0lnbLHzZWjdr2y8MBHiDFamcySYILeqhiTUwbVCn5W3T7H P/GlkdG/6KNCN+/qTQy7KWU5LMlN7S4130oqvanw= Date: Mon, 16 Sep 2024 19:55:43 +0200 From: Greg KH To: Yiyang Wu Subject: Re: [RFC PATCH 02/24] erofs: add superblock data structure in Rust Message-ID: <2024091655-sneeze-pacify-cf28@gregkh> References: <20240916135634.98554-1-toolmanp@tlmp.cc> <20240916135634.98554-3-toolmanp@tlmp.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240916135634.98554-3-toolmanp@tlmp.cc> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, LKML , rust-for-linux@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Mon, Sep 16, 2024 at 09:56:12PM +0800, Yiyang Wu wrote: > diff --git a/fs/erofs/rust/erofs_sys.rs b/fs/erofs/rust/erofs_sys.rs > new file mode 100644 > index 000000000000..0f1400175fc2 > --- /dev/null > +++ b/fs/erofs/rust/erofs_sys.rs > @@ -0,0 +1,22 @@ > +#![allow(dead_code)] > +// Copyright 2024 Yiyang Wu > +// SPDX-License-Identifier: MIT or GPL-2.0-or-later Sorry, but I have to ask, why a dual license here? You are only linking to GPL-2.0-only code, so why the different license? Especially if you used the GPL-2.0-only code to "translate" from. If you REALLY REALLY want to use a dual license, please get your lawyers to document why this is needed and put it in the changelog for the next time you submit this series when adding files with dual licenses so I don't have to ask again :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8B915FA72; Mon, 16 Sep 2024 18:51:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726512662; cv=none; b=aP1CBUqgheQa8S/0hADUzyk9J8yhQQ4lsX3nyAtqSfJypwIuDZjuh6lkXXY1Uq7Ve6XwxcADPh6jwWD1++ZlmpTvE33AADOxNw3ovfHRBIJ8mgttLNrOcBHrf0ptAo0H2uACcVOHoOs8idAf/o5YEL2XKPRoEI52IHVGSlbiwHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726512662; c=relaxed/simple; bh=kmvv0I4Ktqu9r1ximFiGLBL2DIIDeLyJoXWdA9l9kAs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dk9g/BTvHZKFZfpKQWiLjp0uB0Sw0c9ihMvu/b3UG+WnaQwkemZ4JafCgplrpdWw8MBvaEh4t26/9mJYhuJNjUkwjpfL+Ls/ad7olbvqzQJinhxpaiSymvrbwOjhFqb2sgQ/dj4z5ZHHuVNvZVUInyyTAyK2bM4qbxs6z2AJ9i8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VZub7Ckf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VZub7Ckf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C5A3C4CEC4; Mon, 16 Sep 2024 18:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1726512661; bh=kmvv0I4Ktqu9r1ximFiGLBL2DIIDeLyJoXWdA9l9kAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VZub7CkfnbGEVyQuEiC5+fKJkjCjtcPNanvKH5G9tdavMr+MyMgnhMoA6PmrH2O+5 fhV4BJDeKKXX8Qv0A95z0lnbLHzZWjdr2y8MBHiDFamcySYILeqhiTUwbVCn5W3T7H P/GlkdG/6KNCN+/qTQy7KWU5LMlN7S4130oqvanw= Date: Mon, 16 Sep 2024 19:55:43 +0200 From: Greg KH To: Yiyang Wu Cc: linux-erofs@lists.ozlabs.org, rust-for-linux@vger.kernel.org, linux-fsdevel@vger.kernel.org, LKML Subject: Re: [RFC PATCH 02/24] erofs: add superblock data structure in Rust Message-ID: <2024091655-sneeze-pacify-cf28@gregkh> References: <20240916135634.98554-1-toolmanp@tlmp.cc> <20240916135634.98554-3-toolmanp@tlmp.cc> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240916135634.98554-3-toolmanp@tlmp.cc> On Mon, Sep 16, 2024 at 09:56:12PM +0800, Yiyang Wu wrote: > diff --git a/fs/erofs/rust/erofs_sys.rs b/fs/erofs/rust/erofs_sys.rs > new file mode 100644 > index 000000000000..0f1400175fc2 > --- /dev/null > +++ b/fs/erofs/rust/erofs_sys.rs > @@ -0,0 +1,22 @@ > +#![allow(dead_code)] > +// Copyright 2024 Yiyang Wu > +// SPDX-License-Identifier: MIT or GPL-2.0-or-later Sorry, but I have to ask, why a dual license here? You are only linking to GPL-2.0-only code, so why the different license? Especially if you used the GPL-2.0-only code to "translate" from. If you REALLY REALLY want to use a dual license, please get your lawyers to document why this is needed and put it in the changelog for the next time you submit this series when adding files with dual licenses so I don't have to ask again :) thanks, greg k-h