From: Nico Boehr <nrb@linux.ibm.com>
To: borntraeger@linux.ibm.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, david@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH v1 0/2] KVM: s390: fix diag258 virtual-physical confusion
Date: Tue, 17 Sep 2024 17:18:32 +0200 [thread overview]
Message-ID: <20240917151904.74314-1-nrb@linux.ibm.com> (raw)
The parameters for the diag 0x258 are real addresses, not virtual, but
KVM was using them as virtual addresses. This only happened to work, since
the Linux kernel as a guest used to have a 1:1 mapping for physical vs
virtual addresses.
In addition, add handling for guest addresses outside memslots in
access_guest_page() for architectural compliance and testability.
Michael Mueller (1):
KVM: s390: Change virtual to physical address access in diag 0x258
handler
Nico Boehr (1):
KVM: s390: gaccess: check if guest address is in memslot
arch/s390/kvm/diag.c | 2 +-
arch/s390/kvm/gaccess.c | 7 +++++++
arch/s390/kvm/gaccess.h | 14 ++++++++------
3 files changed, 16 insertions(+), 7 deletions(-)
--
2.46.0
next reply other threads:[~2024-09-17 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 15:18 Nico Boehr [this message]
2024-09-17 15:18 ` [PATCH v1 1/2] KVM: s390: gaccess: check if guest address is in memslot Nico Boehr
2024-09-18 10:55 ` Heiko Carstens
2024-09-18 11:03 ` Christian Borntraeger
2024-09-17 15:18 ` [PATCH v1 2/2] KVM: s390: Change virtual to physical address access in diag 0x258 handler Nico Boehr
2024-09-18 10:46 ` Christian Borntraeger
2024-09-18 10:58 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240917151904.74314-1-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.