From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Selvarasu Ganesan <selvarasu.g@samsung.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jh0801.jung@samsung.com" <jh0801.jung@samsung.com>,
"dh10.jung@samsung.com" <dh10.jung@samsung.com>,
"naushad@samsung.com" <naushad@samsung.com>,
"akash.m5@samsung.com" <akash.m5@samsung.com>,
"rc93.raju@samsung.com" <rc93.raju@samsung.com>,
"taehyun.cho@samsung.com" <taehyun.cho@samsung.com>,
"hongpooh.kim@samsung.com" <hongpooh.kim@samsung.com>,
"eomji.oh@samsung.com" <eomji.oh@samsung.com>,
"shijie.cai@samsung.com" <shijie.cai@samsung.com>,
stable <stable@kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: core: Stop processing of pending events if controller is halted
Date: Tue, 17 Sep 2024 22:47:14 +0200 [thread overview]
Message-ID: <2024091758-squeezing-banknote-2704@gregkh> (raw)
In-Reply-To: <da717b2e-e8dc-461f-bef7-d3d9e5df3632@samsung.com>
On Tue, Sep 17, 2024 at 09:52:00PM +0530, Selvarasu Ganesan wrote:
>
> On 9/17/2024 12:38 PM, gregkh@linuxfoundation.org wrote:
> > On Tue, Sep 17, 2024 at 05:47:05AM +0000, Thinh Nguyen wrote:
> >> On Tue, Sep 17, 2024, gregkh@linuxfoundation.org wrote:
> >>> On Mon, Sep 16, 2024 at 11:00:30PM +0000, Thinh Nguyen wrote:
> >>>> On Tue, Sep 17, 2024, Selvarasu Ganesan wrote:
> >>>>> This commit addresses an issue where events were being processed when
> >>>>> the controller was in a halted state. To fix this issue by stop
> >>>>> processing the events as the event count was considered stale or
> >>>>> invalid when the controller was halted.
> >>>>>
> >>>>> Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
> >>>>> Cc: stable <stable@kernel.org>
> >>>> Checkpatch doesn't like that format. Fix the Cc stable tag to below:
> >>>>
> >>>> Cc: stable@kernel.org
> >>> What? Why? That should be fine, exactly what is the warning that this
> >>> gives? That should be fine, as it's what my scripts put into patches
> >>> that I create :)
> >>>
> >> This is what checkpatch complains:
> >>
> >> WARNING:BAD_STABLE_ADDRESS_STYLE: Invalid email format for stable: 'stable <stable@kernel.org>', prefer 'stable@kernel.org'
> >> #23:
> >> Cc: stable <stable@kernel.org>
> >>
> >> total: 0 errors, 1 warnings, 0 checks, 72 lines checked
> > Ugh, that's wrong, whatever you want to do here is fine.
> >
> > Someone should send a patch for checkpatch...
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> However I already posted new version with address a typo mistake as
> well. Kindly review the same.
>
> https://lore.kernel.org/lkml/20240916231813.206-1-selvarasu.g@samsung.com/
It's the middle of the merge window, I'll look at it after -rc1 is out,
thanks.
greg k-h
next prev parent reply other threads:[~2024-09-17 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240916224630epcas5p42b355e2884c665e19d3c9c3a5afd428e@epcas5p4.samsung.com>
2024-09-16 22:45 ` [PATCH v2] usb: dwc3: core: Stop processing of pending events if controller is halted Selvarasu Ganesan
2024-09-16 23:00 ` Thinh Nguyen
2024-09-17 5:36 ` gregkh
2024-09-17 5:47 ` Thinh Nguyen
2024-09-17 7:08 ` gregkh
2024-09-17 16:22 ` Selvarasu Ganesan
2024-09-17 20:47 ` gregkh [this message]
2024-09-17 23:08 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024091758-squeezing-banknote-2704@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=akash.m5@samsung.com \
--cc=dh10.jung@samsung.com \
--cc=eomji.oh@samsung.com \
--cc=felipe.balbi@linux.intel.com \
--cc=hongpooh.kim@samsung.com \
--cc=jh0801.jung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=naushad@samsung.com \
--cc=rc93.raju@samsung.com \
--cc=selvarasu.g@samsung.com \
--cc=shijie.cai@samsung.com \
--cc=stable@kernel.org \
--cc=taehyun.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.