From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FC6C282E5; Wed, 18 Sep 2024 12:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726660927; cv=none; b=TEJ29Zmf7hyXx87EozjJ/WxTyl9Ub6EyWoHZvI/QJf7IabIIrJHILSR8qZafsbzeSA8tTqwKSCWtTF592oMMvAJ6q85bjGKC/9YXqjrSGuG/tHaofKzqrzDE0XTzWQWE+y9Z2+ue5Y4bSml92YvtdOmowjGOctiv0UIck7MV6ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726660927; c=relaxed/simple; bh=9zV0BAFi1NuJZpjoIZAVRCxBV2f3YQrxAA4kfHyPlws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fm58EnvBvHoKFJ+0CGjKQNkZ6SWPorffHQQhJP4bWPFMaHG+lPNhvUUWaILEphCmh3FtmFDVu7CArvKVR0aj6mIKfTTQ4ol1hNxHnh7+SFonjJzYy+ExQpe4BgLv2qKPuIj/7vEJt4BojpwahQaMhoUFL6spqMwQ5Q8vg3eNSUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 6B102227AAD; Wed, 18 Sep 2024 14:01:59 +0200 (CEST) Date: Wed, 18 Sep 2024 14:01:59 +0200 From: Christoph Hellwig To: Kanchan Joshi Cc: Christoph Hellwig , axboe@kernel.dk, kbusch@kernel.org, sagi@grimberg.me, martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jaegeuk@kernel.org, jlayton@kernel.org, chuck.lever@oracle.com, bvanassche@acm.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, gost.dev@samsung.com, vishak.g@samsung.com, javier.gonz@samsung.com, Nitesh Shetty Subject: Re: [PATCH v5 4/5] sd: limit to use write life hints Message-ID: <20240918120159.GA20658@lst.de> References: <20240910150200.6589-5-joshi.k@samsung.com> <20240912130235.GB28535@lst.de> <20240913080659.GA30525@lst.de> <4a39215a-1b0e-3832-93bd-61e422705f8b@samsung.com> <20240917062007.GA4170@lst.de> <20240918064258.GA32627@lst.de> <197b2c1a-66d2-5f5a-c258-7e2f35eff8e4@samsung.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <197b2c1a-66d2-5f5a-c258-7e2f35eff8e4@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Sep 18, 2024 at 01:42:51PM +0530, Kanchan Joshi wrote: > Would you prefer a new queue attribute (say nr_streams) that tells that? No. For one because using the same file descriptors as the one used to set the hind actually makes it usable - finding the block device does not. And second as told about half a dozend time for this scheme to actually work on a regular file the file system actually needs the arbiter, as it can work on top of multiple block devices, consumes streams, might export streams even if the underlying devices don't and so on. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B7C2CCD1A3 for ; Wed, 18 Sep 2024 12:02:17 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1sqtNw-0000uj-L4; Wed, 18 Sep 2024 12:02:16 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sqtNv-0000uc-2O for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Sep 2024 12:02:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sLzKTKWg3g0du0egesNyuK5+3sKuXjEkiax0B9e4gJs=; b=e8w4aVHXbxDiEgB9Bx4l1kSJr2 Bx78KEb6Arq87H2Bw2qOvs6l6S/W5GDVoYQ2seZntw71UpkzzQd+R+C9n1vk2d8hO5KtM+RDk8opH aLg43Y59PRdcRJ3w5umRvdpvEeRIbIjrN+0vc63pymoRpBgDOX2MQOxdrpan2NClkNSY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sLzKTKWg3g0du0egesNyuK5+3sKuXjEkiax0B9e4gJs=; b=bBzTntKqUBe4n+iUK7x0Ht66RS l8k0WuhEPrIQOPuRECNKl2/vIqEMlsapoZ/re32X7JaodHKK0qlw0o+tNiSz4Ao1Yr+4/Z7CQ97c+ +E+r9ILxk1XzknbESdEWf4dcczxIzm1p1Fjy4IlodvusHrnt8cq08scoWbiT+xvXI3/U=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1sqtNt-0003Ef-Eq for linux-f2fs-devel@lists.sourceforge.net; Wed, 18 Sep 2024 12:02:14 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6B102227AAD; Wed, 18 Sep 2024 14:01:59 +0200 (CEST) Date: Wed, 18 Sep 2024 14:01:59 +0200 From: Christoph Hellwig To: Kanchan Joshi Message-ID: <20240918120159.GA20658@lst.de> References: <20240910150200.6589-5-joshi.k@samsung.com> <20240912130235.GB28535@lst.de> <20240913080659.GA30525@lst.de> <4a39215a-1b0e-3832-93bd-61e422705f8b@samsung.com> <20240917062007.GA4170@lst.de> <20240918064258.GA32627@lst.de> <197b2c1a-66d2-5f5a-c258-7e2f35eff8e4@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <197b2c1a-66d2-5f5a-c258-7e2f35eff8e4@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1sqtNt-0003Ef-Eq Subject: Re: [f2fs-dev] [PATCH v5 4/5] sd: limit to use write life hints X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vishak.g@samsung.com, jack@suse.cz, linux-nvme@lists.infradead.org, James.Bottomley@HansenPartnership.com, Christoph Hellwig , sagi@grimberg.me, linux-scsi@vger.kernel.org, gost.dev@samsung.com, Nitesh Shetty , linux-block@vger.kernel.org, viro@zeniv.linux.org.uk, kbusch@kernel.org, jaegeuk@kernel.org, bvanassche@acm.org, axboe@kernel.dk, brauner@kernel.org, martin.petersen@oracle.com, jlayton@kernel.org, linux-f2fs-devel@lists.sourceforge.net, chuck.lever@oracle.com, linux-fsdevel@vger.kernel.org, javier.gonz@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Sep 18, 2024 at 01:42:51PM +0530, Kanchan Joshi wrote: > Would you prefer a new queue attribute (say nr_streams) that tells that? No. For one because using the same file descriptors as the one used to set the hind actually makes it usable - finding the block device does not. And second as told about half a dozend time for this scheme to actually work on a regular file the file system actually needs the arbiter, as it can work on top of multiple block devices, consumes streams, might export streams even if the underlying devices don't and so on. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel