From: Martin Stolpe <martinstolpe@gmail.com>
To: u-boot@lists.denx.de
Cc: Martin Stolpe <martin.stolpe@gmail.com>,
Devarsh Thakkar <devarsht@ti.com>,
Francois Berder <fberder@outlook.fr>,
"Ivan T. Ivanov" <iivanov@suse.de>,
Matthias Brugger <mbrugger@suse.com>,
Nikhil M Jain <n-jain1@ti.com>,
Peter Robinson <pbrobinson@gmail.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Tom Rini <trini@konsulko.com>
Subject: [PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi
Date: Fri, 20 Sep 2024 08:32:01 +0200 [thread overview]
Message-ID: <20240920063204.1049202-2-martin.stolpe@gmail.com> (raw)
In-Reply-To: <20240920063204.1049202-1-martin.stolpe@gmail.com>
When the CONFIG_VIDEO option is set to disabled for Raspberry Pi devices
the build will fail with the following error message:
"undefined reference to `fdt_simplefb_enable_and_mem_rsv'."
Signed-off-by: Martin Stolpe <martin.stolpe@gmail.com>
---
board/raspberrypi/rpi/rpi.c | 2 +-
boot/fdt_simplefb.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c
index ab5ea85cf9..bc49708f85 100644
--- a/board/raspberrypi/rpi/rpi.c
+++ b/board/raspberrypi/rpi/rpi.c
@@ -572,7 +572,7 @@ int ft_board_setup(void *blob, struct bd_info *bd)
node = fdt_node_offset_by_compatible(blob, -1, "simple-framebuffer");
if (node < 0)
fdt_simplefb_add_node(blob);
- else
+ else if (IS_ENABLED(CONFIG_VIDEO))
fdt_simplefb_enable_and_mem_rsv(blob);
#ifdef CONFIG_EFI_LOADER
diff --git a/boot/fdt_simplefb.c b/boot/fdt_simplefb.c
index 5341554845..b6e916ff7d 100644
--- a/boot/fdt_simplefb.c
+++ b/boot/fdt_simplefb.c
@@ -86,6 +86,7 @@ int fdt_simplefb_add_node(void *blob)
return fdt_simplefb_configure_node(blob, off);
}
+#if IS_ENABLED(CONFIG_VIDEO)
/**
* fdt_simplefb_enable_existing_node() - enable simple-framebuffer DT node
*
@@ -103,7 +104,6 @@ static int fdt_simplefb_enable_existing_node(void *blob)
return fdt_simplefb_configure_node(blob, off);
}
-#if IS_ENABLED(CONFIG_VIDEO)
int fdt_simplefb_enable_and_mem_rsv(void *blob)
{
int ret;
--
2.43.0
next prev parent reply other threads:[~2024-09-20 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 6:32 [PATCH 0/1] rpi: Fix compilation when CONFIG_VIDEO is disabled Martin Stolpe
2024-09-20 6:32 ` Martin Stolpe [this message]
2024-09-20 8:16 ` [PATCH 1/1] rpi: Fix build error when CONFIG_VIDEO is disabled for Raspberry Pi Ivan T. Ivanov
2024-09-24 6:26 ` Martin Stolpe
2024-09-24 6:38 ` Devarsh Thakkar
2024-09-26 12:26 ` Martin Stolpe
2024-09-26 16:45 ` Devarsh Thakkar
2024-10-07 12:54 ` Martin Stolpe
2024-10-07 13:02 ` Devarsh Thakkar
2024-10-11 12:22 ` Martin Stolpe
2024-10-11 12:33 ` Peter Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920063204.1049202-2-martin.stolpe@gmail.com \
--to=martinstolpe@gmail.com \
--cc=devarsht@ti.com \
--cc=fberder@outlook.fr \
--cc=iivanov@suse.de \
--cc=martin.stolpe@gmail.com \
--cc=mbrugger@suse.com \
--cc=n-jain1@ti.com \
--cc=pbrobinson@gmail.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.